[SYCL][Cmake] Add SYCL_LIBDEVICE_GCC_TOOLCHAIN variable #7771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would passing the right, non-standard absolute paths to |
No, for several reasons:
|
To be used when we want libdevice built against non-system STL (e.g. if we're using non-system GCC) as clang doesn't use gcc in PATH to determine which STL to use.
aelovikov-intel
force-pushed
the
libdevice_gcc_toolchain
branch
from
7f77afd to
62b8e72
Compare
bader
approved these changes
Jan 3, 2023
|
@intel/llvm-gatekeepers , this PR is ready. |
againull
approved these changes
Jan 4, 2023
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Apr 21, 2023
…its.hpp Re-commits intel#7628 and intel#7668 that were previously reverted due to build issues on RHEL systems. The issues were fixed by introducing `SYCL_LIBDEVICE_GCC_TOOLCHAIN` cmake configuration option in intel#7771.
againull
pushed a commit
that referenced
this pull request
Apr 24, 2023
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Aug 11, 2023
…tests The same has been done in libdevice in intel#7771. We need this internally where we have a build on an older RHEL with gcc in non-system location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be used when we want libdevice built against non-system STL (e.g. if we're using non-system GCC) as clang doesn't use gcc in PATH to determine which STL to use.