Skip to content

[CI] Update drivers installation process into containers #7730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 15, 2022

Conversation

pvchupin
Copy link
Contributor

@pvchupin pvchupin commented Dec 10, 2022

  • Install level_zero loader and headers as part of the drivers installation. Should be installed as dependency into containers, rather than built and shipped with the compiler.
  • Add level_zero to update_drivers.py
  • Fix CM install. Takes version from dependencies.json rather than always the latest.
  • Exclude u18 CM package from consideration. Before it was installing u18 then u20 and produced a warning.
  • Update "unstable" containers build by always taking the "latest" packages rather than relying on prior definition of staging versions.
  • Clean up dependencies.json and erase specific staging versions. We stopped updating these earlier.

Should be installed as dependency, rather than built and shipped with
the compiler
@pvchupin pvchupin requested a review from a team as a code owner December 10, 2022 07:44
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, take a look at pre-commit failures.

"level_zero": {
"github_tag": "v1.8.8",
"version": "v1.8.8",
"url": "https://github.com/oneapi-src/level-zero/releases/tag/v1.8.8",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This URL points to Level Zero loader and I think the runtime is installed as part of compute-runtime package. Isn't loader installed with compute-runtime as well?
If not, I'm okay with installing the loader, but PR title should be corrected.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loader is not installed as part of the compute-runtime.
Here is content for the record. Here is what is installed with compute-runtime package:

dpkg-query -L intel-level-zero-gpu
/.                                                        
/usr                                                      
/usr/include                                              
/usr/lib                                                  
/usr/lib/x86_64-linux-gnu                                 
/usr/lib/x86_64-linux-gnu/libze_intel_gpu.so.1.3.24278    
/usr/share                                                
/usr/share/doc                                            
/usr/share/doc/intel-level-zero-gpu                       
/usr/share/doc/intel-level-zero-gpu/changelog.gz          
/usr/share/doc/intel-level-zero-gpu/copyright             
/var                                                      
/var/lib                                                  
/var/lib/libze_intel_gpu                                  
/var/lib/libze_intel_gpu/pci_bind_status_file             
/var/lib/libze_intel_gpu/wedged_file                      
/usr/lib/x86_64-linux-gnu/libze_intel_gpu.so.1

And here is what this PR adds:

dpkg-query -L level-zero                       
/usr                                                                   
/usr/lib                                                               
/usr/lib/x86_64-linux-gnu                                              
/usr/lib/x86_64-linux-gnu/libze_loader.so.1.8.8                        
/usr/lib/x86_64-linux-gnu/libze_tracing_layer.so.1.8.8                 
/usr/lib/x86_64-linux-gnu/libze_validation_layer.so.1.8.8              
/usr/lib/x86_64-linux-gnu/libze_loader.so.1                            
/usr/lib/x86_64-linux-gnu/libze_tracing_layer.so.1                     
/usr/lib/x86_64-linux-gnu/libze_validation_layer.so.1                  

dpkg-query -L level-zero-devel                 
/usr                                                                   
/usr/include                                                           
/usr/include/level_zero                                                
/usr/include/level_zero/layers                                         
/usr/include/level_zero/layers/zel_tracing_api.h                       
/usr/include/level_zero/layers/zel_tracing_ddi.h                       
/usr/include/level_zero/layers/zel_tracing_register_cb.h               
/usr/include/level_zero/loader                                         
/usr/include/level_zero/loader/ze_loader.h                             
/usr/include/level_zero/ze_api.h                                       
/usr/include/level_zero/ze_ddi.h                                       
/usr/include/level_zero/zes_api.h                                      
/usr/include/level_zero/zes_ddi.h                                      
/usr/include/level_zero/zet_api.h                                      
/usr/include/level_zero/zet_ddi.h                                      
/usr/lib                                                               
/usr/lib/x86_64-linux-gnu                                              
/usr/lib/x86_64-linux-gnu/pkgconfig                                    
/usr/lib/x86_64-linux-gnu/pkgconfig/level-zero.pc                      
/usr/lib/x86_64-linux-gnu/pkgconfig/libze_loader.pc                    
/usr/lib/x86_64-linux-gnu/libze_loader.so                              
/usr/lib/x86_64-linux-gnu/libze_tracing_layer.so                       
/usr/lib/x86_64-linux-gnu/libze_validation_layer.so                  

@pvchupin pvchupin changed the title [CI] Install level_zero runtime as part of the drivers installation [CI] Install level_zero loader and headers as part of the drivers installation Dec 13, 2022
@pvchupin pvchupin changed the title [CI] Install level_zero loader and headers as part of the drivers installation [CI] Update drivers installation process into containers Dec 13, 2022
@pvchupin pvchupin requested a review from bader December 13, 2022 04:27
@pvchupin
Copy link
Contributor Author

Made quite a few changes, so please re-review. Note that generate test matrix fails because old version of dependencies.json don't have level_zero component defined.

@bader bader requested a review from smaslov-intel December 13, 2022 16:47
@@ -40,47 +46,6 @@
"root": "{ARCHIVE_ROOT}/comp/oclfpga/linux"
}
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nice thing about staging is that we know the versions of the dependencies. How do we know what "latest" is?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latest is a moving tag.
Exact versions can be found in a container build logs or from the inside of the container through package manager commands, like:

# apt list --installed | grep intel-igc-cm                                                                                        
intel-igc-cm/now 1.0.119 amd64 [installed,local]                               

@igchor
Copy link
Member

igchor commented Dec 14, 2022

@pvchupin @smaslov-intel is the plan to do the same with Unified Runtime loader (install into the containers)?

@smaslov-intel
Copy link
Contributor

@pvchupin @smaslov-intel is the plan to do the same with Unified Runtime loader (install into the containers)?

Yes, eventually Unified Runtime would a side project installed separately and not by the compiler.

@pvchupin pvchupin merged commit cc59d77 into intel:sycl Dec 15, 2022
@pvchupin pvchupin deleted the l0 branch December 15, 2022 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants