Skip to content

Undo a bit of fcf4e360ba6b that confuses MSVC #7664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

pvchupin
Copy link
Contributor

@pvchupin pvchupin commented Dec 6, 2022

clang\lib\Serialization\GlobalModuleIndex.cpp(818): error C2440: 'initializing': cannot convert from 'const ValueTy' to '_Ty2 &&'
with
[
ValueTy=llvm::SmallVector<unsigned int,2>
]
and
[
_Ty2=llvm::SmallVector<unsigned int,2>
]

clang\lib\Serialization\GlobalModuleIndex.cpp(818): error C2440: 'initializing': cannot convert from 'const ValueTy' to '_Ty2 &&'
        with
        [
            ValueTy=llvm::SmallVector<unsigned int,2>
        ]
        and
        [
            _Ty2=llvm::SmallVector<unsigned int,2>
        ]
@pvchupin pvchupin requested a review from a team as a code owner December 6, 2022 19:59
@pvchupin
Copy link
Contributor Author

pvchupin commented Dec 6, 2022

This is a cherry-pick from upstream to fix post-commit-issue on Windows: https://github.com/intel/llvm/actions/runs/3631775825/jobs/6126831597
that was introduced at: #7640

@aelovikov-intel
Copy link
Contributor

Can we have a link to the upstream patch here?

@pvchupin
Copy link
Contributor Author

pvchupin commented Dec 6, 2022

@pvchupin pvchupin merged commit 08505f2 into intel:sycl Dec 6, 2022
@pvchupin pvchupin deleted the fix-post-commit branch December 6, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants