Skip to content

[SYCL][FPGA][NFC] Change the identifier names #7596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 5, 2022
Merged

[SYCL][FPGA][NFC] Change the identifier names #7596

merged 2 commits into from
Dec 5, 2022

Conversation

smanna12
Copy link
Contributor

@smanna12 smanna12 commented Nov 30, 2022 •
edited
Loading

This patch changes the identifier names because
we do not use FPGA attribute spelling anymore (Ref:
#4532)

Fixes #5105

Signed-off-by: Soumi Manna soumi.manna@intel.com

@smanna12
[SYCL][FPGA][NFC] Change the identifier names
afd8a8d 
This patch changes the identifier names because
we do not use FPGA spelling anymore (Ref:
intel#4532)

Fixes intel#5105
@smanna12 smanna12 marked this pull request as ready for review November 30, 2022 20:44
@smanna12 smanna12 requested a review from a team as a code owner November 30, 2022 20:44
@premanandrao
Copy link
Contributor

It looks like these are all name changes from IntelFPGA to SYCLIntel and from SYCLIntelFPGA to SYCLIntel, and these are okay to me. But there are some that changed from IntelFPGA... to Intel... (and not SYCLIntel...). Is this intentional? Are the new spellings/mappings listed somewhere?

@smanna12
Copy link
Contributor Author

smanna12 commented Dec 1, 2022

. But there are some that changed from IntelFPGA... to Intel... (and not SYCLIntel...). Is this intentional? Are the new spellings/mappings listed somewhere?

Thanks @premanandrao for reviews! This is intentional . I thought to update them as well by removing FPGA. Those are not listed anywhere. If you prefer, i could leave them unchanged

@premanandrao
Copy link
Contributor

If you prefer, i could leave them unchanged

My suggestion would be to change them to SYCLIntel... to be consistent with the other similar changes.

@smanna12
Copy link
Contributor Author

smanna12 commented Dec 1, 2022

If you prefer, i could leave them unchanged

My suggestion would be to change them to SYCLIntel... to be consistent with the other similar changes.

Done. Thanks @premanandrao for the suggestion.

@smanna12
Copy link
Contributor Author

smanna12 commented Dec 5, 2022

ping @premanandrao

@smanna12
Copy link
Contributor Author

smanna12 commented Dec 5, 2022

Thanks for the reviews, everyone!

@smanna12
Copy link
Contributor Author

smanna12 commented Dec 5, 2022

Failings do not seem related to my PR.

@intel/llvm-gatekeepers, this PR is ready for merge. Thank you

@pvchupin pvchupin merged commit 94894ee into intel:sycl Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@premanandrao premanandrao premanandrao approved these changes

@elizabethandrews elizabethandrews elizabethandrews approved these changes

@MrSidims MrSidims Awaiting requested review from MrSidims

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SYCL][FPGA] Change the identifier names? e.g. SYCLIntelFPGAIVDep?
4 participants
@smanna12 @premanandrao @elizabethandrews @pvchupin