[SYCL-MLIR]: Remove mlir inlining pass #7536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tiotto, Ettore <ettore.tiotto@intel.com>
etiotto
requested review from
arnamoy10,
sommerlukas,
victor-eds and
whitneywhtsang
|
Note: I am working on a proper inlining pass. I plan to add an 'always inliner' pass to inline callees that have the 'alwaysinline' function attribute (now that we have the ability to annotate mlir functions with attributes). Subsequently I will work on a SCC inliner with a proper set of heuristcs. At that point we can adjust the |
Co-authored-by: Whitney Tsang <54643204+whitneywhtsang@users.noreply.github.com>
|
@whitneywhtsang anything preventing you to approve this PR ? |
Co-authored-by: Whitney Tsang <54643204+whitneywhtsang@users.noreply.github.com>
whitneywhtsang
approved these changes
Nov 24, 2022
Co-authored-by: Whitney Tsang <54643204+whitneywhtsang@users.noreply.github.com>
Signed-off-by: Tiotto, Ettore <ettore.tiotto@intel.com>
victor-eds
approved these changes
Nov 25, 2022
etiotto
added a commit
that referenced
this pull request
Nov 28, 2022
PR #7536 removed the MLIR inlining pass (too greedy). This PR introduces an 'always-inline' pass in the `cgeist` MLIR pipeline. This pass inlines only `sycl.call` call sites with callee that has the 'alwaysinline' mlir function attribute. The pass uses a generic SCC inliner to perform its actions and specializes the inlining heuristic used at outline above. Signed-off-by: Tiotto, Ettore <ettore.tiotto@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cgeistuses the stock MLIR inlining pass in its pass pipeline. The MLIR inlining pass has no heuristic and is essentially a greedy inliner, that is, as long as callees do not contain any operation deemed illegal for inlining by their dialects, it inlines all callees irrespective of any cost considerations (size, hotness, etc...).Without a proper cost model, the MLIR inlining pass is not useful to our use case. This PR removes the inlining pass from the cgeist mlir pass pipeline and adjust test cases accordingly.