Skip to content

[SYCL][NFC] Reduce amount of includes in in-tree tests #7438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AlexeySachkov
Copy link
Contributor

@AlexeySachkov AlexeySachkov commented Nov 17, 2022

This PR is an attempt to speed up our in-tree tests, main changes are the following:

  • add -fsyntax-only to tests which don't launch compiled binaries
  • replace single sycl/sycl.hpp include with several includes for only necessary things
  • refactored some tests so they don't require queue at all

Had to do some adjustments to a couple of SYCL header files to make them useable in isolation.

Currently, single check-sycl pass takes ~110+ seconds in GitHub Actions. Let's see how that can be improved

Mainly replaced a single `sycl/sycl.hpp` include with more specific
headers which are needed for each test.
@bader
Copy link
Contributor

bader commented Jan 5, 2023

@AlexeySachkov, ping.

@AlexeySachkov
Copy link
Contributor Author

@AlexeySachkov, ping.

@bader, I though about this PR and I don't think that it worth much to reduce amount of includes in those headers: I don't see any compile-time improvement, but the maintenance cost increases. Therefore, I will close this PR.

However, there are couple of improvements which could be done anyway:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants