[SYCL] Plugin Interface Changes to query a list of function pointers. #731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- created a plugin as a shared plugin: lib/libpi_opencl.so. Moved the sources to new location plugins/opencl. - removed the dependency on pi.cpp by pi_opencl.cpp - added the preliminary plugin recognition mechanism and loading the plugin as a shared object using dlopen/dlsym etc. Signed-off-by: Garima Gupta <garima.gupta@intel.com>
Signed-off-by: Garima Gupta <garima.gupta@intel.com>
Signed-off-by: Garima Gupta <garima.gupta@intel.com>
plugin:pi_opencl.cpp - changed the dependency to pi.h, which contains declarations and no other defined macros or defintions. Signed-off-by: Garima Gupta <garima.gupta@intel.com>
garimagu
force-pushed
the
private/garimagu/pi_function_table2
branch
2 times, most recently
from
935a767 to
e259fe4
Compare
- Plugin now keeps a list of the function pointers in a predetermined order. - A single dlsym call is made returning the location of this list. - The PI function pointers are populated using offsets and this location. Signed-off-by: Garima Gupta <garima.gupta@intel.com>
garimagu
force-pushed
the
private/garimagu/pi_function_table2
branch
from
e259fe4 to
7f3389e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review only the last commit. The other commits are under review at #708
order.
location.
Signed-off-by: Garima Gupta garima.gupta@intel.com