[SYCL] Propagate sycl_fixed_targets metadata #7115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of optional kernel features implementation we need to implement new compiler switch option "-fsycl-fixed-targets=target,target..." to diagnose optional feature usage and mark SYCL kernel functions with a "!sycl_fixed_targets !N" metadata, where "!N" is list of targets as aspects enum members. This patch applies changes for SYCLPropagateAspectsUsage pass and prepare it to accept new switch from Clang.
AlexeySachkov
previously requested changes
Oct 20, 2022
llvm/test/SYCLLowerIR/PropagateAspectsUsage/sycl-fixed-targets.ll
Outdated
Show resolved
Hide resolved
KornevNikita
requested review from
AlexeySachkov,
steffenlarsen and
dm-vodopyanov
steffenlarsen
requested changes
Oct 21, 2022
|
@AlexeySachkov @intel/dpcpp-esimd-reviewers take a look, please |
Co-authored-by: Alexey Sachkov <alexey.sachkov@intel.com>
…ita/llvm into propagate-fixed-target
AlexeySachkov
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of optional kernel features implementation we need to implement new compiler switch option "-fsycl-fixed-targets=target,target..." to diagnose optional feature usage and mark SYCL kernel functions with a "!sycl_fixed_targets !N" metadata, where "!N" is a list of targets as aspects enum members.
This patch applies changes for SYCLPropagateAspectsUsage pass and prepare it to accept new switch from Clang.