[NFCI][SYCL] Eliminate UB in ANSI alias violation accessing ByteArray's #7023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of it provide a nicer (IMO) interface to it. Also, asserts are now moved into the underlying utility functions making it easier to read the core logic up the call stack.
aelovikov-intel
commented
Oct 11, 2022
| // The map is not locked here because updateSpecConstSymMap() is | ||
| // only supposed to be called from c'tor. | ||
| MSpecConstSymMap[std::string{SCName}].push_back( | ||
| SpecConstDescT{/*ID*/ It[0], /*CompositeOffset*/ It[1], | ||
| /*Size*/ It[2], BlobOffset}); | ||
| SpecConstDescT{Id, CompositeOffset, Size, BlobOffset}); |
There was a problem hiding this comment.
Could be
MSpecConstSymMap[std::string{SCName}].emplace_back(Id, CompositeOffset, Size, BlobOffset);
but should be done in a different PR (if at all).
This was referenced Oct 11, 2022
steffenlarsen
approved these changes
Oct 12, 2022
| T Val; | ||
| std::memcpy(&Val, Ptr, sizeof(T)); | ||
| Ptr += sizeof(T); | ||
| Size -= sizeof(T); |
There was a problem hiding this comment.
Nit, but you could call dropBytes(sizeof(T)) here instead. Should make maintainability a little easier, in case something else comes along that needs to be mutated with every move.
There was a problem hiding this comment.
It evaluates the assert one more time now, but that should be fine.
|
@intel/llvm-gatekeepers , this PR is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of it provide a nicer (IMO) interface to it. Also, asserts are now moved into the underlying utility functions making it easier to read the core logic up the call stack.