Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Implement subset of sycl_ext_oneapi_kernel_properties #7018

Merged

Conversation

steffenlarsen
Copy link
Contributor

This commit implements the following parts of the
sycl_ext_oneapi_kernel_properties extension:

  • The work_group_size, work_group_size_hint, and sub_group_size properties.
  • The new overloads for single_task, parallel_for, and parallel_for_work_group in handler.
  • The new shortcuts for single_task and parallel_for in queue.
  • Support for merging property lists which is used when kernel functors have a get member for properties. The changes do not include any changes related to the device_has property and corresponding interfaces.

This is split from #6941.

This commit implements the following parts of the
sycl_ext_oneapi_kernel_properties extension:
* The work_group_size, work_group_size_hint, and sub_group_size
properties.
* The new overloads for single_task, parallel_for, and
parallel_for_work_group in handler.
* The new shortcuts for single_task and parallel_for in queue.
* Support for merging property lists which is used when kernel functors
have a get member for properties. The changes do not include any changes
related to the device_has property and corresponding interfaces.

This is split from intel#6941.

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
@steffenlarsen
Copy link
Contributor Author

This currently requires #7016 and #7017, so it is marked as draft.

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
@steffenlarsen
Copy link
Contributor Author

Dependencies have been merged. This is ready for review.

@steffenlarsen steffenlarsen marked this pull request as ready for review October 13, 2022 18:08
@steffenlarsen steffenlarsen requested review from a team as code owners October 13, 2022 18:08
Copy link
Contributor

@cperkinsintel cperkinsintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had one remark on the enum, but LGTM otherwise.

@steffenlarsen
Copy link
Contributor Author

/verify with intel/llvm-test-suite#1302

@steffenlarsen
Copy link
Contributor Author

/verify with intel/llvm-test-suite#1302

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
@steffenlarsen
Copy link
Contributor Author

/verify with intel/llvm-test-suite#1302

@steffenlarsen
Copy link
Contributor Author

ESIMD verification failures on windows are unrelated and will be addressed with #7103.

@steffenlarsen steffenlarsen merged commit 70ee3d5 into intel:sycl Oct 18, 2022
@steffenlarsen
Copy link
Contributor Author

Post-commit failures addressed in #7109 and #7110.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants