[SYCL] Do not decompose arrays with pointers #7015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

pvchupin merged 6 commits into intel:sycl from elizabethandrews:DontDecomposeArray

Oct 13, 2022

Contributor

elizabethandrews commented Oct 11, 2022 •

edited

Loading

Arrays with pointers are no longer decomposed into array elements when generating openCL kernel arguments.

Signed-off-by: Elizabeth Andrews elizabeth.andrews@intel.com


          [SYCL] Do not decompose arrays with pointers

43c9dd0

Arrays are no longer decomposed into its elements.

Signed-off-by: Elizabeth Andrews <elizabeth.andrews@intel.com>

elizabethandrews requested a review from a team as a code owner

October 11, 2022 03:01

premanandrao reviewed

View reviewed changes

clang/lib/Sema/SemaSYCL.cpp Show resolved Hide resolved

clang/lib/Sema/SemaSYCL.cpp Outdated Show resolved Hide resolved

clang/lib/Sema/SemaSYCL.cpp Show resolved Hide resolved

premanandrao reviewed

View reviewed changes

clang/lib/Sema/SemaSYCL.cpp Show resolved Hide resolved

smanna12 reviewed

View reviewed changes

clang/lib/Sema/SemaSYCL.cpp Outdated Show resolved Hide resolved

smanna12 reviewed

View reviewed changes

clang/lib/Sema/SemaSYCL.cpp Outdated Show resolved Hide resolved

smanna12 reviewed

View reviewed changes

clang/lib/Sema/SemaSYCL.cpp Show resolved Hide resolved

smanna12 reviewed

View reviewed changes

clang/lib/Sema/SemaSYCL.cpp Outdated Show resolved Hide resolved

smanna12 reviewed

View reviewed changes

clang/lib/Sema/SemaSYCL.cpp Show resolved Hide resolved


          Apply review comments

2dfe874

Signed-off-by: Elizabeth Andrews <elizabeth.andrews@intel.com>

Fznamznon reviewed

View reviewed changes

clang/lib/Sema/SemaSYCL.cpp Outdated Show resolved Hide resolved

clang/lib/Sema/SemaSYCL.cpp Outdated Show resolved Hide resolved

clang/lib/Sema/SemaSYCL.cpp Outdated Show resolved Hide resolved

clang/lib/Sema/SemaSYCL.cpp Show resolved Hide resolved

clang/lib/Sema/SemaSYCL.cpp Show resolved Hide resolved

clang/lib/Sema/SemaSYCL.cpp Show resolved Hide resolved

clang/lib/Sema/SemaSYCL.cpp Outdated Show resolved Hide resolved

clang/test/CodeGenSYCL/pointers-in-structs.cpp Show resolved Hide resolved

elizabethandrews added 2 commits

October 12, 2022 09:54


          Apply review comments

28a35da

Signed-off-by: Elizabeth Andrews <elizabeth.andrews@intel.com>


          Apply review comment

d60780a

Signed-off-by: Elizabeth Andrews <elizabeth.andrews@intel.com>

Fznamznon approved these changes

View reviewed changes

elizabethandrews requested review from smanna12 and premanandrao

October 12, 2022 18:17

smanna12 approved these changes

View reviewed changes

premanandrao approved these changes

View reviewed changes

Contributor

pvchupin commented Oct 13, 2022

@elizabethandrews, please resolve conflicts

elizabethandrews added 2 commits

October 13, 2022 07:56


          Merge remote-tracking branch 'intel_llvm/sycl' into DontDecomposeArray

81dfe20


          Merge remote-tracking branch 'intel_llvm/sycl' into DontDecomposeArray

83930d7

Contributor Author

elizabethandrews commented Oct 13, 2022 •

edited

Loading

@intel/llvm-gatekeepers PR is ready for review and merge

pvchupin merged commit d4478a4 into intel:sycl

Contributor

pvchupin commented Oct 13, 2022

@elizabethandrews, please follow up on post-commit issues on Windows: https://github.com/intel/llvm/actions/runs/3245312292

Failed Tests (2):
  Clang :: SemaSYCL/array-kernel-param.cpp
  Clang :: SemaSYCL/built-in-type-kernel-arg.cpp

elizabethandrews mentioned this pull request

[NFC] Fix fail on Windows #7064

Merged

Contributor Author

elizabethandrews commented Oct 14, 2022

@elizabethandrews, please follow up on post-commit issues on Windows: https://github.com/intel/llvm/actions/runs/3245312292
Failed Tests (2):
  Clang :: SemaSYCL/array-kernel-param.cpp
  Clang :: SemaSYCL/built-in-type-kernel-arg.cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet