[SYCL] Fix deprecation of device selectors #6965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to SYCL 1.2.1 device selectors being callable, they would fall into the SYCL 2020 interface rather than into the deprecated interfaces. To amend this, the trait for checking for callables has been changed to exclude subclasses of device_selector. Additionally this commit clarifies the deprecation messages to avoid capitalization of "Callable" and referencing the related SYCL specification versions for old and new interfaces. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
|
LGTM! |
rolandschulz
approved these changes
Oct 5, 2022
…_selector_deprecation
|
@npmiller | @AidanBeltonS - The HIP failures here seem unrelated to the changes, but I do not see them failing on other PRs. Could you please advise? |
|
I've had a look into this and it's quite strange, I'm not able to reproduce it with either MI100 or MI50, and I've also tried on tip and on your branch and I get no issues. However it does look like we've had similar issues with other atomic tests before: So I think it should be okay to ignore these/mark them unsupported until we can properly debug them on the same architecture as the CI. |
|
Thank you, @npmiller! I will rerun tests after intel/llvm-test-suite#1318 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to SYCL 1.2.1 device selectors being callable, they would fall into the SYCL 2020 interface rather than into the deprecated interfaces. To amend this, the trait for checking for callables has been changed to exclude subclasses of device_selector.
Additionally this commit clarifies the deprecation messages to avoid capitalization of "Callable" and referencing the related SYCL specification versions for old and new interfaces.