Skip to content

[SYCL] Rename optional device feature metadata #6822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2022
Merged

[SYCL] Rename optional device feature metadata #6822

merged 1 commit into from
Sep 23, 2022

Conversation

steffenlarsen
Copy link
Contributor

This commit renames metadata nodes introduced by the optional device features design document from using intel_ prefix to use sycl_ prefix.

@steffenlarsen
[SYCL] Rename optional device feature metadata
136bc19 
This commit renames metadata nodes introduced by the optional device
features design document from using `intel_` prefix to use `sycl_`
prefix.

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
@steffenlarsen steffenlarsen requested review from a team as code owners September 20, 2022 11:33
@steffenlarsen
Copy link
Contributor Author

Related to discussion #6804 (comment)

elizabethandrews
elizabethandrews reviewed Sep 20, 2022
View reviewed changes
Copy link
Contributor

@elizabethandrews elizabethandrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steffenlarsen I see you've changed the documentation for intel_fixed_targets but I don't see where you actually changed the name in code. Can you plase point me to it?

asudarsa
asudarsa approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@asudarsa asudarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I suppose intel_reqd_group_size will also be renamed? In a separate patch maybe?

Thanks

@steffenlarsen
Copy link
Contributor Author

@steffenlarsen I see you've changed the documentation for intel_fixed_targets but I don't see where you actually changed the name in code. Can you plase point me to it?

intel_fixed_targets has not been introduced yet, so no actual changes are needed for it.

I suppose intel_reqd_group_size will also be renamed? In a separate patch maybe?

intel_reqd_group_size is not new to the optional device features design so the renaming should happen separately.

@elizabethandrews
Copy link
Contributor

@steffenlarsen I see you've changed the documentation for intel_fixed_targets but I don't see where you actually changed the name in code. Can you plase point me to it?

intel_fixed_targets has not been introduced yet, so no actual changes are needed for it.

Thanks for clarifying!

@smanna12 smanna12 mentioned this pull request Sep 20, 2022
Open
@smanna12
Copy link
Contributor

I suppose intel_reqd_group_size will also be renamed? In a separate patch maybe?

intel_reqd_group_size is not new to the optional device features design so the renaming should happen separately.

I have created #6824 for this

@steffenlarsen steffenlarsen merged commit 04c54fb into intel:sycl Sep 23, 2022
@smanna12 smanna12 mentioned this pull request Oct 4, 2022
Closed
@smanna12 smanna12 mentioned this pull request Dec 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader approved these changes

@gmlueck gmlueck gmlueck approved these changes

@Fznamznon Fznamznon Fznamznon approved these changes

@elizabethandrews elizabethandrews elizabethandrews approved these changes

@smanna12 smanna12 smanna12 approved these changes

@asudarsa asudarsa asudarsa approved these changes

@AlexeySachkov AlexeySachkov Awaiting requested review from AlexeySachkov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@steffenlarsen @elizabethandrews @smanna12 @bader @gmlueck @Fznamznon @asudarsa