[SYCL] Add profiling info for host execution #679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bader
reviewed
Sep 26, 2019
sndmitriev
force-pushed
the
public/sndmitriev/sycl-host-profiling-info
branch
from
f84cd50 to
960b224
Compare
Done. |
romanovvlad
requested changes
Sep 27, 2019
| @@ -128,6 +128,9 @@ Command::Command(CommandType Type, QueueImplPtr Queue, bool UseExclusiveQueue) | |||
| MEvent.reset(new detail::event_impl()); | |||
| MEvent->setCommand(this); | |||
| MEvent->setContextImpl(detail::getSyclObjImpl(MQueue->get_context())); | |||
| if (MQueue->is_host() && | |||
There was a problem hiding this comment.
Why are you doing it here? I think this code should be in event_impl c'tor.
There was a problem hiding this comment.
Moved this to event_impl c'tor.
Signed-off-by: Sergey Dmitriev <serguei.n.dmitriev@intel.com>
sndmitriev
force-pushed
the
public/sndmitriev/sycl-host-profiling-info
branch
from
960b224 to
39b9cb2
Compare
romanovvlad
approved these changes
Sep 29, 2019
vladimirlaz
pushed a commit
that referenced
this pull request
Sep 29, 2020
Experimental support of extra DWARF operations As this functionality is not documented by any formal SPIR-V extension or SPIR-V extended instruction set specification, it is disabled by default and in order to enable generation of extra debug information, user needs to pass `spirv-allow-extra-diexpressions` command line option to the translator. Signed-off-by: Andrew Savonichev <andrew.savonichev@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sergey Dmitriev serguei.n.dmitriev@intel.com