Skip to content

[SYCL][NFC] Fix aspects detection of AllocaInst when opaque pointers are enabled #6767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 20, 2022
Merged

[SYCL][NFC] Fix aspects detection of AllocaInst when opaque pointers are enabled #6767

merged 2 commits into from
Sep 20, 2022

Conversation

AlexeySachkov
Copy link
Contributor

No description provided.

@AlexeySachkov AlexeySachkov requested a review from bader September 13, 2022 12:22
@AlexeySachkov AlexeySachkov requested a review from a team as a code owner September 13, 2022 12:22
@AlexeySachkov AlexeySachkov mentioned this pull request Sep 13, 2022
Merged
unterumarmung
unterumarmung reviewed Sep 13, 2022
View reviewed changes
@bader
Copy link
Contributor

bader commented Sep 20, 2022

@AlexeySachkov, @intel/dpcpp-tools-reviewers, ping.

@AlexeySachkov AlexeySachkov force-pushed the private/asachkov/fix-propagate-usages-pass-tests-with-opaque-pointers branch from b3f6ab4 to 477a07e Compare September 20, 2022 15:03
@AlexeySachkov
Copy link
Contributor Author

I apologize for the force-push, accidentally merged with the wrong branch.

asudarsa
asudarsa approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@asudarsa asudarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. Is there a test in place for this?

@bader
Copy link
Contributor

bader commented Sep 20, 2022

LGTM. Thanks. Is there a test in place for this?

Yes. There are regression tests in sycl/llvm/test/SYCLLowerIR/PropagateAspectsUsage, which are failing in nightly. This patch is supposed to fix these failures.

@bader bader merged commit 50bc1e9 into intel:sycl Sep 20, 2022
@AlexeySachkov AlexeySachkov deleted the private/asachkov/fix-propagate-usages-pass-tests-with-opaque-pointers branch May 22, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unterumarmung unterumarmung unterumarmung left review comments

@asudarsa asudarsa asudarsa approved these changes

@bader bader Awaiting requested review from bader

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexeySachkov @bader @unterumarmung @asudarsa