Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][NFC] Remove some references to the past use of extended members #6595

Merged
merged 1 commit into from
Aug 22, 2022
Merged

[SYCL][NFC] Remove some references to the past use of extended members #6595

merged 1 commit into from
Aug 22, 2022

Conversation

sergey-semenov
Copy link
Contributor

No description provided.

@sergey-semenov sergey-semenov requested a review from a team as a code owner August 17, 2022 15:16
smaslov-intel
smaslov-intel approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@smaslov-intel smaslov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sergey-semenov
Copy link
Contributor Author

@intel/llvm-gatekeepers Could you please merge this one?

@steffenlarsen steffenlarsen merged commit 6cfde8b into intel:sycl Aug 22, 2022
@sergey-semenov sergey-semenov mentioned this pull request Sep 20, 2022
Merged
bader pushed a commit that referenced this pull request Sep 27, 2022
@sergey-semenov
[SYCL] Fix an issue when spec constants are set in a CG w/o a kernel (#…
b333cee 
…6826)

Fix an issue introduced by #6595.
Removing the version check also removed the implicit check for whether
we have a command group at all, which caused a CTS regression.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smaslov-intel smaslov-intel smaslov-intel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sergey-semenov @smaslov-intel @steffenlarsen