[SYCL] Fix compare_exchange_strong to properly update Expected inout param #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…param For device code, __spirv_AtomicCompareExchange doesn't seem to update the Expected parameter, new value is simply returned instead. However, SYCL's API requires the updated value to be passed through inout parameter - do so. Signed-off-by: Andrei Elovikov <andrei.elovikov@intel.com>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…tel/llvm-test-suite#665) As shown by CI for intel#569, the unsupported combination of opencl && acc still shows up. Attempt to fix this by using a common operator style as a follow-up to intel#652. Signed-off-by: Artem Gindinson <artem.gindinson@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For device code, __spirv_AtomicCompareExchange doesn't seem to update the
Expected parameter, new value is simply returned instead. However, SYCL's API
requires the updated value to be passed through inout parameter - do so.
Signed-off-by: Andrei Elovikov andrei.elovikov@intel.com