[SYCL] Move SYCL headers from CL/ to sycl/ #6407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/verify with intel/llvm-test-suite#1078 |
1 similar comment
|
/verify with intel/llvm-test-suite#1078 |
aelovikov-intel
force-pushed
the
move-includes
branch
from
a3f9996
to
a85b135
Compare
aelovikov-intel
added a commit
to aelovikov-intel/llvm-test-suite
that referenced
this pull request
Jul 8, 2022
Also, CL/sycl.hpp -> sycl/sycl.hpp. This change is complementary to intel/llvm#6407.
aelovikov-intel
force-pushed
the
move-includes
branch
from
a85b135
to
04321e7
Compare
|
/verify with intel/llvm-test-suite#1078 |
aelovikov-intel
force-pushed
the
move-includes
branch
from
04321e7
to
8bea505
Compare
|
/verify with intel/llvm-test-suite#1078 |
aelovikov-intel
force-pushed
the
move-includes
branch
from
8bea505
to
5e3b22c
Compare
|
/verify with intel/llvm-test-suite#1078 |
Quoting SYCL 2020: For compatibility with SYCL 1.2.1, SYCL provides another standard header file: <CL/sycl.hpp>, which can be included in place of <sycl/sycl.hpp>. In that case, all SYCL classes, constants, types and functions defined by this specification should exist within the ::cl::sycl C++ namespace.
aelovikov-intel
force-pushed
the
move-includes
branch
from
eb00399
to
256919f
Compare
|
/verify with intel/llvm-test-suite#1078 |
aelovikov-intel
dismissed stale reviews from smanna12, smaslov-intel, premanandrao, and cperkinsintel
via
e6cc0fb
bader
reviewed
Jul 12, 2022
|
/verify with intel/llvm-test-suite#1078 |
|
@intel/dpcpp-specification-reviewers , can you please take a look at the relevant part of this? |
asudarsa
previously approved these changes
Jul 12, 2022
v-klochkov
previously approved these changes
Jul 12, 2022
smanna12
previously approved these changes
Jul 12, 2022
aelovikov-intel
dismissed stale reviews from jbrodman, smanna12, v-klochkov, and asudarsa
via
3cbd819
smanna12
approved these changes
Jul 13, 2022
|
/verify with intel/llvm-test-suite#1078 |
jbrodman
approved these changes
Jul 13, 2022
smaslov-intel
approved these changes
Jul 13, 2022
yhmtsai
added a commit
to yhmtsai/oneMKL
that referenced
this pull request
Aug 1, 2022
yhmtsai
added a commit
to yhmtsai/oneMKL
that referenced
this pull request
Aug 1, 2022
4 tasks
mkrainiuk
pushed a commit
to oneapi-src/oneMKL
that referenced
this pull request
Aug 31, 2022
* use the correct sycl path after intel/llvm#6407 * fix the missing sycl/sycl.hpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CL/sycl.hppis changed to includesycl/sycl.hpp.No deprecation warning emitted as the header is required by the SYCL 2020
for backward compatibility.