[SYCL] Fail on kernel lambda size mismatch #6374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some host-compilers may create lambdas with captures that do not match the ones used when extracting kernel descriptors. The compiler does not currently have a stable way of handling these cases, so instead this PR adds a static assertion that the sizes match with a message informing about the limitation. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
bader
approved these changes
Jun 29, 2022
| using type = FalseT; | ||
| }; | ||
|
|
||
| using int64_t = conditional<sizeof(long) == 8, long, long long>::type; |
There was a problem hiding this comment.
Ideally we should check that sizeof(long long) is 8, if sizeof(long) != 8.
There was a problem hiding this comment.
I agree, but this mimics the decision made by SemaSYCL when generating the specialization, so it should be fine for our testing.
|
@v-klochkov - Friendly ping. |
v-klochkov
reviewed
Jul 8, 2022
| @@ -13,6 +13,8 @@ | |||
| #include <CL/sycl/detail/defines_elementary.hpp> | |||
| #include <CL/sycl/detail/export.hpp> | |||
|
|
|||
| #include <cstdint> | |||
There was a problem hiding this comment.
Nice, perhaps this will also fix one of internal trackers reporting problems with undefined int8_t type slipped into integration-header file.
There was a problem hiding this comment.
This inclusion is giving oneapi/dpl a stomach ache.
There was a problem hiding this comment.
v-klochkov
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some host-compilers may create lambdas with captures that do not match the ones used when extracting kernel descriptors. The compiler does not currently have a stable way of handling these cases, so instead this PR adds a static assertion that the sizes match with a message informing about the limitation.