[SYCL] Fix properties include dependency in fpga extensions #6101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpga_lsu.hpp uses the compile-time properties extension but does not include the corresponding header file. This issue only shows up when the fpga extension header (or fpga_lsu.hpp directly) is included before sycl.hpp. These changes resolves the include dependency. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
|
Thank you for catching this, Steffen! I didn't realize you don't have to include <sycl.hpp> first. Could you apply the same change to experimental/pipes.hpp which has the same issue? |
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
changed the title
Good call! It has been added to this PR and the description has been changed accordingly. |
v-klochkov
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fpga_lsu.hpp and pipes.hpp use the compile-time properties extension but do not include the corresponding header file. This issue only shows up when the fpga extension header (or fpga_lsu.hpp/pipes.hpp directly) is included before sycl.hpp. These changes resolves the include dependency.