[SYCL][L0] Fix BDF format on PCI query #6011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PCI address currently reported by the L0 backend does not correctly report domain, bus, device, and function as hexadecimal values. This commit changes the reported format to use convert the values hexadecimal representation. Additionally it also pads the values with leading zeros. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
|
@smaslov-intel - To my knowledge the padding is not strictly required as part of the BDF format, but it makes the reported values more consistent and easier for users to parse. If you prefer not to include it, please let me know and I will remove it. |
smaslov-intel
previously approved these changes
Apr 14, 2022
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
New test is up here: intel/llvm-test-suite#991 It also showed that |
|
/verify with intel/llvm-test-suite#991 |
smaslov-intel
approved these changes
Apr 14, 2022
|
Unexpected pass in KernelAndProgram/undefined-symbol.cpp on Windows. This is known and should be fixed with intel/llvm-test-suite#994 with GPU uplift. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PCI address currently reported by the L0 backend does not correctly report domain, bus, device, and function as hexadecimal values. This commit changes the reported format to use convert the values hexadecimal representation. Additionally it also pads the values with leading zeros.