[SYCL][ESIMD][EMU] Merging buffer/image info to surface info #5930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongkyunahn-intel
requested review from
steffenlarsen and
lsatanov
and removed request for
steffenlarsen
lsatanov
reviewed
Mar 30, 2022
lsatanov
reviewed
Mar 30, 2022
lsatanov
reviewed
Mar 30, 2022
| PiBuf->SurfacePtr.UPBufPtr); | ||
| } else if (Mem->SurfacePtr.tag == cm_surface_ptr_t::type_regular_buffer) { | ||
| _pi_buffer *PiBuf = static_cast<_pi_buffer *>(Mem); | ||
| Status = Mem->Context->Device->CmDevicePtr->DestroySurface( |
There was a problem hiding this comment.
Could this functionality be encapsulated in destrutor of _pi_mem ?
lsatanov
reviewed
Mar 31, 2022
kbobrovs
reviewed
Apr 28, 2022
| @@ -105,9 +107,28 @@ struct _pi_queue : _pi_object { | |||
| cm_support::CmQueue *CmQueuePtr = nullptr; | |||
| }; | |||
|
|
|||
| struct _pi_mem : _pi_object { | |||
| _pi_mem() = default; | |||
| struct cm_surface_ptr_t { | |||
There was a problem hiding this comment.
Please add later comments what is this structure for.
kbobrovs
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to merge cm buffer info and cm image info into one surface_info struct. Suggested in #5606.
Comment : https://github.com/intel/llvm/pull/5606/files#r831642498, https://github.com/intel/llvm/pull/5606/files#r836308878