[SYCL][Doc] Adjust design for compile-time properties through add_ir_annotations_member #5884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…annotations_member During implementation of the attribute and translation of annotations on fields, the design was conflicting with existing features. This commit makes the following design changes: * Change the `llvm.ptr.annotation` intrinsic call produced by `[[__sycl_detail__::add_ir_annotations_member()]]` to use a pointer to a constant global variable instead of metadata. This is done to adhere to the signature of the intrinsic. * Change the representation consumed by the translator from a new SPIR-V builtin to an extended version of existing decoration parsing using `llvm.ptr.annotation`. Signed-off-by: Steffen Larsen <steffen.larsen@intel.com>
gmlueck
reviewed
Mar 24, 2022
Signed-off-by: Steffen Larsen <steffen.larsen@intel.com>
gmlueck
reviewed
Mar 25, 2022
Signed-off-by: Steffen Larsen <steffen.larsen@intel.com>
gmlueck
reviewed
Mar 25, 2022
Signed-off-by: Steffen Larsen <steffen.larsen@intel.com>
gmlueck
previously approved these changes
Mar 25, 2022
|
The SPIR-V translator changes have been merged and the FE (#5879) has one approval. As such I think we can move this out of draft. |
ghost
reviewed
Apr 1, 2022
| * The third parameter is the name of the source file (as with any call to this | ||
| intrinsic). | ||
| * The fourth parameter is the line number (as with any call to this intrinsic). | ||
| * The fifth parameter is a pointer to a constant global variable. The type of |
There was a problem hiding this comment.
Is it allowed adding parameters to the @llvm.ptr.annotation intrinsic? In the LangRef only 4 parameters are described.
There was a problem hiding this comment.
That is curious. According to the intrinsic definition in Intrinsics.td it has 5 parameters, the last being another i8 *. It does not seem to be a recent change so I think maybe someone forgot to update the LangRef?
gmlueck
reviewed
Apr 8, 2022
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
gmlueck
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During implementation of the attribute and translation of annotations on fields, the design was conflicting with existing features. This commit makes the following design changes:
llvm.ptr.annotationintrinsic call produced by[[__sycl_detail__::add_ir_annotations_member()]]to use a pointer to a constant global variable instead of metadata. This is done to adhere to the signature of the intrinsic.llvm.ptr.annotation.Implementation of these are in review #5879 and KhronosGroup/SPIRV-LLVM-Translator#1446