[SYCL] Ensure correct sycl::errc for SYCL2020 #5582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… code. This ensures that it does. Signed-off-by: Chris Perkins <chris.perkins@intel.com>
Signed-off-by: Chris Perkins <chris.perkins@intel.com>
…e correct errc value. Signed-off-by: Chris Perkins <chris.perkins@intel.com>
Signed-off-by: Chris Perkins <chris.perkins@intel.com>
… the error. Signed-off-by: Chris Perkins <chris.perkins@intel.com>
…ption Signed-off-by: Chris Perkins <chris.perkins@intel.com>
…ss mode Signed-off-by: Chris Perkins <chris.perkins@intel.com>
…ation Signed-off-by: Chris Perkins <chris.perkins@intel.com>
…nvalid is used Signed-off-by: Chris Perkins <chris.perkins@intel.com>
Signed-off-by: Chris Perkins <chris.perkins@intel.com>
Signed-off-by: Chris Perkins <chris.perkins@intel.com>
… for range Signed-off-by: Chris Perkins <chris.perkins@intel.com>
Signed-off-by: Chris Perkins <chris.perkins@intel.com>
|
/verify with intel/llvm-test-suite#857 |
alexbatashev
previously approved these changes
Feb 23, 2022
Signed-off-by: Chris Perkins <chris.perkins@intel.com>
alexbatashev
approved these changes
Feb 26, 2022
bader
changed the title
|
/verify with intel/llvm-test-suite#857 |
|
ping to someone who can merge. @romanovvlad or @bader or others. This and its brother-in-test intel/llvm-test-suite#857 are ready and approved. |
romanovvlad
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Mar 3, 2022
in intel/llvm#5582 we are adding an update that ensures that the errc of any exception is correct as specified in the SYCL2020 spec. Here we are updating and expanding the tests to accompany Signed-off-by: Chris Perkins chris.perkins@intel.com
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…suite#857) in intel#5582 we are adding an update that ensures that the errc of any exception is correct as specified in the SYCL2020 spec. Here we are updating and expanding the tests to accompany Signed-off-by: Chris Perkins chris.perkins@intel.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SYCL2020 specification has quite a few errc values it expects thrown exceptions to have. Most of the existing ones are fine, but there are several cases that need updating. After this there are some other changes that will need to be done for errc conformance, but those changes are slightly more involved and I did not undertake them here. I'll open separate PRs for those.
This PR may seem to touch a lot of files, but they are each small independent accesses. If it's easier to grok, just go through the individual commits.
The tests were updated as well. intel/llvm-test-suite#857 has the matching changes.