[SYCL][DOC] Fixed-size private arrays as an input for Group Algorithms #5571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pennycook
previously requested changes
Feb 14, 2022
sycl/doc/extensions/proposed/SYCL_EXT_ONEAPI_GROUP_STATIC_ARRAY.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/SYCL_EXT_ONEAPI_GROUP_STATIC_ARRAY.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/SYCL_EXT_ONEAPI_GROUP_STATIC_ARRAY.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/SYCL_EXT_ONEAPI_GROUP_STATIC_ARRAY.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/SYCL_EXT_ONEAPI_GROUP_STATIC_ARRAY.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/SYCL_EXT_ONEAPI_GROUP_STATIC_ARRAY.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/SYCL_EXT_ONEAPI_GROUP_STATIC_ARRAY.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/SYCL_EXT_ONEAPI_GROUP_STATIC_ARRAY.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/SYCL_EXT_ONEAPI_GROUP_STATIC_ARRAY.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/SYCL_EXT_ONEAPI_GROUP_STATIC_ARRAY.asciidoc
Outdated
Show resolved
Hide resolved
gmlueck
reviewed
Feb 14, 2022
sycl/doc/extensions/proposed/SYCL_EXT_ONEAPI_GROUP_STATIC_ARRAY.asciidoc
Outdated
Show resolved
Hide resolved
|
It is not clear to me what you mean by static array here. |
Sorry, I mean fixed-size arrays, e.g. |
andreyfe1
changed the title
gmlueck
reviewed
Sep 20, 2022
sycl/doc/extensions/proposed/sycl_ext_oneapi_group_sort.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/sycl_ext_oneapi_group_sort.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/sycl_ext_oneapi_group_sort.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/sycl_ext_oneapi_group_sort.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/sycl_ext_oneapi_group_sort.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/sycl_ext_oneapi_group_sort.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/sycl_ext_oneapi_group_sort.asciidoc
Outdated
Show resolved
Hide resolved
gmlueck
approved these changes
Nov 15, 2022
romanovvlad
dismissed
Pennycook’s stale review
All comments were addressed. @Pennycook, please let us know if there are any concerns, so we will address them in a follow up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For performance reasons it's better to process fixed-size arrays of variables in private memory using Group Algorithms. The proposal introduces such capability.
Based on following extensions:
Signed-off-by: Fedorov, Andrey andrey.fedorov@intel.com