[SYCL][L0] Remove ZeModule when program build failed #5541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Byoungro So <byoungro.so@intel.com>
When a sycl::program is attempted to build, a ZeModule is created. When the attempt failed, we need to clean up the ZeModule that is associated with the failed program to avoid memory leak. Signed-off-by: Byoungro So <byoungro.so@intel.com>
bso-intel
added a commit
to bso-intel/llvm-test-suite
that referenced
this pull request
Feb 10, 2022
As I fixed memory leak of ZeModule in intel/llvm#5541, we need to enable ZE_DEBUG=4 check for these tests. Signed-off-by: Byoungro So <byoungro.so@intel.com>
smaslov-intel
suggested changes
Feb 11, 2022
Signed-off-by: Byoungro So <byoungro.so@intel.com>
Co-authored-by: smaslov-intel <sergey.v.maslov@intel.com>
smaslov-intel
previously approved these changes
Feb 11, 2022
Signed-off-by: Byoungro So <byoungro.so@intel.com>
…to buildfail-leak
Signed-off-by: Byoungro So <byoungro.so@intel.com>
Signed-off-by: Byoungro So <byoungro.so@intel.com>
Co-authored-by: smaslov-intel <sergey.v.maslov@intel.com>
smaslov-intel
suggested changes
Feb 18, 2022
Signed-off-by: Byoungro So <byoungro.so@intel.com>
…to buildfail-leak
Signed-off-by: Byoungro So <byoungro.so@intel.com>
Signed-off-by: Byoungro So <byoungro.so@intel.com>
smaslov-intel
approved these changes
Feb 19, 2022
smaslov-intel
pushed a commit
to smaslov-intel/llvm
that referenced
this pull request
Feb 19, 2022
When a sycl::program is attempted to build, a ZeModule is created. When the attempt failed, we need to clean up the ZeModule that is associated with the failed program to avoid memory leak.
vladimirlaz
added a commit
to intel/llvm-test-suite
that referenced
this pull request
Feb 21, 2022
* [SYCL] enable ZE_DEBUG=4 tests As I fixed memory leak of ZeModule in intel/llvm#5541, we need to enable ZE_DEBUG=4 check for these tests. Signed-off-by: Byoungro So <byoungro.so@intel.com> Co-authored-by: vladimirlaz <vladimir.lazarev@intel.com>
alexbatashev
added a commit
to alexbatashev/llvm
that referenced
this pull request
Feb 23, 2022
* upstream/sycl: (2757 commits) [SYCL][Doc] Fixing incorrect merge of community Readme.md with our version (intel#5636) [SYCL] Change USM pooling parameters. (intel#5457) [CI] Fix cache location on Windows (intel#5603) [SYCL][NFC] Fix a warning about uninitialized struct members (intel#5610) [Buildbot] Update Windows GPU version to 101.1340 (intel#5620) Fix SPIRV -> OCL barrier call argument attributes Move SPV_INTEL_memory_access_aliasing tokens from spirv_internal [SYCL][ESIMD] Add support for named barrier APIs (intel#5583) [SYCL][L0] Remove ZeModule when program build failed (intel#5541) [SYCL] Silence "unknown attribute" warning for `device_indirectly_callable` (intel#5591) [SYCL][DOC] Introductory material for extensions (intel#5605) [SYCL][DOC] Change extension names to lower case (intel#5607) [SYCL] Improve get_kernel_bundle performance (intel#5496) [SYCL] Do not build device code for sub-devices (intel#5240) [sycl-post-link] Fix a crash during spec-constant properties generation (intel#5538) [SYCL][DOC] Move SPIR-V and OpenCL extensions (intel#5578) [SYCL][ESIMD][EMU] Update memory intrinsics for ESIMD_EMU plugin (intel#4748) [CI] Allow stale issue bot to analyze more issues (intel#5602) [SYCL][L0] Honor property::queue::enable_profiling (intel#5543) [OpenMP] Properly save strings when doing LTO ...
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
* [SYCL] enable ZE_DEBUG=4 tests As I fixed memory leak of ZeModule in intel#5541, we need to enable ZE_DEBUG=4 check for these tests. Signed-off-by: Byoungro So <byoungro.so@intel.com> Co-authored-by: vladimirlaz <vladimir.lazarev@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a sycl::program is attempted to build, a ZeModule is created.
When the attempt failed, we need to clean up the ZeModule that is associated with the failed program to avoid memory leak.