-
Notifications
You must be signed in to change notification settings - Fork 772
[CI][NewPM] Turn on nightly testing with the new PM set by default #5340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI][NewPM] Turn on nightly testing with the new PM set by default #5340
Conversation
Signed-off-by: Mikhail Lychkov <mikhail.lychkov@intel.com>
Signed-off-by: Mikhail Lychkov <mikhail.lychkov@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to change main workflow file. It can be customized from outside.
Co-authored-by: Alexander Batashev <alexbatashev@outlook.com>
Signed-off-by: Mikhail Lychkov <mikhail.lychkov@intel.com>
This is great. Thanks a lot. |
Signed-off-by: Mikhail Lychkov <mikhail.lychkov@intel.com>
@mlychkov, one of the tests hangs(?) with new PM. Please, investigate the root cause. |
It has been found that new PM option didn't set properly and clang was still built with legacy PM for new tests. So, the test hung on compiler with legacy PM. I'll create an issue. |
Failed 'SYCL Nightly Builds / ubuntu2004_build_test_new_pm' is expected because not all patches that fix SYCL optimization pipeline using new PM have been merged yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fix these tests before merging this change.
…or_nightly_testing
Failed tests are a new regression since last testing. I will create a new issue for that. |
@mlychkov could you please tell number of failing tests? |
Failed Tests (5): These tests have been added in 5373362 Issue #5473 is raised. |
@bader All initial fixes have been merged into main branch. There is a new regression for new PM, but I think that it'd be better to merge this PR and just start to create issues for new regressions. Otherwise, another regression may occur while we fix current one and so on. |
I would prefer the job to pass. Is it possible to mark failing tests as "expected to fail with new pass manager"? |
I've summarized what is different for the legacy pass manager case and temporarily disabled the tests here : #5475 I'll try to understand why the the variable names change for the different pass managers. |
…or_nightly_testing
This time tests failed again due to test host connectivity issues. |
@bader Restarted pre-commit has passed: http://llvm-ci-test2.intel.com:8080/blue/organizations/jenkins/SYCL_CI%2Fintel%2FLin%2FBasic_E2E/detail/Basic_E2E/761/pipeline/ |
Signed-off-by: Mikhail Lychkov mikhail.lychkov@intel.com