Skip to content

[CI][NewPM] Turn on nightly testing with the new PM set by default #5340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mlychkov
Copy link
Contributor

Signed-off-by: Mikhail Lychkov mikhail.lychkov@intel.com

Signed-off-by: Mikhail Lychkov <mikhail.lychkov@intel.com>
Signed-off-by: Mikhail Lychkov <mikhail.lychkov@intel.com>
@mlychkov mlychkov requested a review from alexbatashev January 19, 2022 13:55
@mlychkov mlychkov requested a review from bader as a code owner January 19, 2022 13:55
Copy link
Contributor

@alexbatashev alexbatashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to change main workflow file. It can be customized from outside.

mlychkov and others added 2 commits January 20, 2022 09:40
Co-authored-by: Alexander Batashev <alexbatashev@outlook.com>
Signed-off-by: Mikhail Lychkov <mikhail.lychkov@intel.com>
@mlychkov
Copy link
Contributor Author

You don't need to change main workflow file. It can be customized from outside.

This is great. Thanks a lot.

alexbatashev
alexbatashev previously approved these changes Jan 20, 2022
Signed-off-by: Mikhail Lychkov <mikhail.lychkov@intel.com>
@bader
Copy link
Contributor

bader commented Jan 20, 2022

@mlychkov, one of the tests hangs(?) with new PM. Please, investigate the root cause.

@mlychkov
Copy link
Contributor Author

@mlychkov, one of the tests hangs(?) with new PM. Please, investigate the root cause.

It has been found that new PM option didn't set properly and clang was still built with legacy PM for new tests. So, the test hung on compiler with legacy PM. I'll create an issue.

@mlychkov
Copy link
Contributor Author

Failed 'SYCL Nightly Builds / ubuntu2004_build_test_new_pm' is expected because not all patches that fix SYCL optimization pipeline using new PM have been merged yet.

Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix these tests before merging this change.

@mlychkov
Copy link
Contributor Author

mlychkov commented Feb 2, 2022

Failed tests are a new regression since last testing. I will create a new issue for that.

@olegmaslovatintel
Copy link

@mlychkov could you please tell number of failing tests?

@mlychkov
Copy link
Contributor Author

mlychkov commented Feb 4, 2022

@mlychkov could you please tell number of failing tests?

Failed Tests (5):
SYCL :: check_device_code/matrix/matrix-nvptx-bf16-test.cpp
SYCL :: check_device_code/matrix/matrix-nvptx-half-float-test.cpp
SYCL :: check_device_code/matrix/matrix-nvptx-half-half-test.cpp
SYCL :: check_device_code/matrix/matrix-nvptx-int8-test.cpp
SYCL :: check_device_code/matrix/matrix-nvptx-uint8-test.cpp

These tests have been added in 5373362

Issue #5473 is raised.

@mlychkov
Copy link
Contributor Author

mlychkov commented Feb 4, 2022

Let's fix these tests before merging this change.

@bader All initial fixes have been merged into main branch. There is a new regression for new PM, but I think that it'd be better to merge this PR and just start to create issues for new regressions. Otherwise, another regression may occur while we fix current one and so on.

@bader
Copy link
Contributor

bader commented Feb 4, 2022

I would prefer the job to pass. Is it possible to mark failing tests as "expected to fail with new pass manager"?

@JackAKirk
Copy link
Contributor

I would prefer the job to pass. Is it possible to mark failing tests as "expected to fail with new pass manager"?

I've summarized what is different for the legacy pass manager case and temporarily disabled the tests here : #5475

I'll try to understand why the the variable names change for the different pass managers.

@mlychkov
Copy link
Contributor Author

This time tests failed again due to test host connectivity issues.

@mlychkov
Copy link
Contributor Author

@bader bader merged commit e6d0547 into intel:sycl Feb 10, 2022
@mlychkov mlychkov deleted the private/mlychkov/newPM_add_gh_action_for_nightly_testing branch February 15, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants