Skip to content

[SYCL] Emit program build logs for warning levels >= 2 #5319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 4, 2022
Merged

[SYCL] Emit program build logs for warning levels >= 2 #5319

merged 3 commits into from
Feb 4, 2022

Conversation

alexbatashev
Copy link
Contributor

@alexbatashev alexbatashev commented Jan 17, 2022 •
edited
Loading

When SYCL_RT_WARNING_LEVEL is set to 2 or higher, a program build log will be printed to std::clog.

@alexbatashev alexbatashev requested a review from s-kanaev January 17, 2022 10:03
s-kanaev
s-kanaev reviewed Jan 17, 2022
View reviewed changes
@alexbatashev
Copy link
Contributor Author

/verify with intel/llvm-test-suite#753

@alexbatashev alexbatashev marked this pull request as ready for review January 24, 2022 07:12
@alexbatashev alexbatashev requested a review from a team as a code owner January 24, 2022 07:12
@alexbatashev
Copy link
Contributor Author

/verify with intel/llvm-test-suite#753

@alexbatashev
Copy link
Contributor Author

/verify with intel/llvm-test-suite#753

@alexbatashev
Copy link
Contributor Author

@s-kanaev ping

@alexbatashev alexbatashev requested a review from s-kanaev January 26, 2022 13:42
s-kanaev
s-kanaev approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@s-kanaev s-kanaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sycl/source/detail/program_manager/program_manager.cpp
/// met, namely when SYCL_RT_WARNING_LEVEL is greater than or equal to 2.
static void emitBuiltProgramInfo(const pi_program &Prog,
const ContextImplPtr &Context) {
if (SYCLConfig<SYCL_RT_WARNING_LEVEL>::get() >= 2) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: 2 got to have a name here. Suggest add naming in separate patch when we're to add some behaviour for another value e.g. 1.

@bader
Copy link
Contributor

bader commented Jan 27, 2022

/verify with intel/llvm-test-suite#753

@bader
Copy link
Contributor

bader commented Jan 28, 2022

Verification with intel/llvm-test-suite#753 fails on Windows. @alexbatashev, please, fix regressions.

@alexbatashev
Copy link
Contributor Author

@bader I don't see how this patch could have caused that. The same tests pass on OpenCL backend for GPUs and CPUs, and only fail on L0. I can disable these tests and open a tracker.

@bader
Copy link
Contributor

bader commented Jan 30, 2022

/verify with intel/llvm-test-suite#753

@bader
Copy link
Contributor

bader commented Jan 30, 2022

SYCL :: Basic/image/image_accessor_readsampler.cpp is failing. Is it related to this patch?

@alexbatashev
Copy link
Contributor Author

/verify with intel/llvm-test-suite#753

@bader bader mentioned this pull request Feb 4, 2022
Merged
@bader bader merged commit 008519a into intel:sycl Feb 4, 2022
alexbatashev added a commit to alexbatashev/llvm that referenced this pull request Feb 5, 2022
@alexbatashev
Merge remote-tracking branch 'upstream/sycl' into rework_pi_mock
f05d63a 
* upstream/sycl: (3571 commits)
  [ESIMD] Doxygen update part III - core APIs. (intel#5472)
  [SYCL][DOC] Move proposed FPGA extensions (intel#5453)
  [SYCL] Add -fsycl-fp32-prec-sqrt flag (intel#5309)
  [SYCL] Emit program build logs for warning levels >= 2 (intel#5319)
  [SYCL] Add clang support for code_location in KernelInfo (intel#5335)
  [SYCL][Doc] Move FPGA extensions (intel#5470)
  [ESIMD] Fix public simd and simd_view APIs. (intel#5465)
  [SYCL] Deprecate sycl::atomics in SYCL 2020 mode (intel#5440)
  [SYCL] Add unit test for PR 5414 (intel#5450)
  [XPTI] Allow arbitrary data types in metadata (intel#4998)
  [SYCL][DOC] Move discard queue events to supported (intel#5452)
  [Driver][SYCL] Initial support for allowing fat static -lname processing (intel#5413)
  [SYCL] Fix dead pointer usage if leaf buffer overflows (intel#5417)
  [SYCL][L0] Fix memory leak in USM prefetch (intel#5461)
  [SYCL][Doc] Add new free function queries proposal (intel#5106)
  [SYCL][ESIMD] Update vc-intrinsics deps to the top of the trunk (intel#5460)
  [SYCL][DOC] Move old spec constant extension spec (intel#5456)
  [SYCL][DOC] Move deprecated extensions (intel#5458)
  [SYCL][DOC] Fix links to old SubGroupMask doc (intel#5459)
  [ESIMD] Doxygen update part II - memory APIs. (intel#5443)
  ...
@AerialMantis AerialMantis mentioned this pull request Feb 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-kanaev s-kanaev s-kanaev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexbatashev @bader @s-kanaev