[SYCL] Diagnose unresolved symbols in L0 modules #5267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmlueck
changed the base branch from
private/gmlueck/l0-static-linking3-a
to
sycl
Diagnose an error in the Level Zero version of `piProgramBuild` and `piProgramLink` if the built program has any unresolved symbols. Also, include an error message with a list of the unresolved symbols in the build log, which is incorporated into the `what` string of the exception that the runtime throws. As a result, the user will see a list of the unresolved symbols when the exception terminates the application. Previously, no error was diagnosed from `piProgramBuild` or `piProgramLink` when there were unresolved symbols, but the first call to `piKernelCreate` would fail (without any indication about the cause of the failure).
gmlueck
force-pushed
the
gmlueck/l0-static-linking3-b
branch
from
1450d95 to
47afd78
Compare
|
I have retargeted this PR and rebased it, now that #5266 is merged. Note that I have a new E2E test ready, which tests this error condition. I'll create a PR with that new test once I understand the process of adding a new E2E test. |
smaslov-intel
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diagnose an error in the Level Zero version of
piProgramBuildandpiProgramLinkif the built program has any unresolved symbols. Also,include an error message with a list of the unresolved symbols in the
build log, which is incorporated into the
whatstring of theexception that the runtime throws. As a result, the user will see a
list of the unresolved symbols when the exception terminates the
application.
Previously, no error was diagnosed from
piProgramBuildorpiProgramLinkwhen there were unresolved symbols, but the first callto
piKernelCreatewould fail (without any indication about the causeof the failure).
There is a test case for this PR in intel/llvm-test-suite#712