[SYCL] Add supplemental tool for SPIR-V to LLVM-IR conversions #5157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tool name: spir-to-ir Function: Provides an interface used within the compiler driver toolchain which converts SPIR-V to LLVM-IR. Using llvm-spirv as the main conversion tool, the purpose of this is to be able to take binaries and convert them to LLVM-IR. The conversion only takes place if the input is SPIR-V, and if the LLVM-IR is provided it is simply copied and passed through. This tool is useful for handling generated fat objects/archives that contain SPIR-V as opposed to typical LLVM-IR. We do not now the type of files within the device objects, so we use this tool to make sure that file consumed after unbundling is always LLVM-IR. Example usage: spir-to-ir input.spv -o output.bc // creates LLVM-IR output.bc spir-to-ir input.bc -o output.bc // no conversion, creates output.bc
AGindinson
reviewed
Dec 16, 2021
AGindinson
reviewed
Dec 21, 2021
AGindinson
reviewed
Dec 28, 2021
AGindinson
previously approved these changes
Dec 28, 2021
There was a problem hiding this comment.
The implementation LGTM! On top of the @intel/llvm-reviewers-runtime approval, conceptual approvals from @AlexeySachkov, @AlexeySotkin would be really appreciated.
|
SPIR and SPIR-V are quite different things. I'd recommend to rename |
AGindinson
approved these changes
Dec 29, 2021
|
@intel/llvm-reviewers-runtime, ping. |
sergey-semenov
approved these changes
Dec 30, 2021
AlexeySachkov
approved these changes
Dec 30, 2021
|
@mdtoguchi, build with linking shared LLVM libraries has failed in post-commit. Please, take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tool name:
spirv-to-ir-wrapper
Function:
Provides an interface used within the compiler driver toolchain which
converts SPIR-V to LLVM-IR. Using llvm-spirv as the main conversion
tool, the purpose of this is to be able to take binaries and convert
them to LLVM-IR. The conversion only takes place if the input is
SPIR-V, and if the LLVM-IR is provided it is simply copied and
passed through.
This tool is useful for handling generated fat objects/archives that
contain SPIR-V as opposed to typical LLVM-IR. We do not know the
type of files within the device objects, so we use this tool to make
sure that file consumed after unbundling is always LLVM-IR.
Example usage:
spirv-to-ir-wrapper input.spv -o output.bc // creates LLVM-IR output.bc
spirv-to-ir-wrapper input.bc -o output.bc // no conversion, creates output.bc