Skip to content

[LIBCLC][PTX] Fix logical bug in mul_hi for smaller datatypes #4802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2021
Merged

[LIBCLC][PTX] Fix logical bug in mul_hi for smaller datatypes #4802

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2aefb2b
Fixing logical bug in mul_hi for smaller datatypes
Oct 22, 2021
458cc6d
Clang formatting
Oct 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion libclc/ptx-nvidiacl/libspirv/integer/mul_hi.cl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ _CLC_OVERLOAD _CLC_DEF ulong __spirv_ocl_u_mul_hi(ulong x, ulong y) {

#define __CLC_MUL_HI_IMPL(BGENTYPE, SPV_MUL_HI, GENTYPE, GENSIZE) \
_CLC_OVERLOAD _CLC_DEF GENTYPE SPV_MUL_HI(GENTYPE x, GENTYPE y) { \
return (GENTYPE)(SPV_MUL_HI((BGENTYPE)x, (BGENTYPE)y) >> GENSIZE); \
return (GENTYPE)SPV_MUL_HI((BGENTYPE)(((BGENTYPE)x) << GENSIZE), \
(BGENTYPE)y); \
}

__CLC_MUL_HI_IMPL(short, __spirv_ocl_s_mul_hi, char, 8)
Expand Down