[Driver][SYCL][FPGA] implied default device forces emulation #4801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using -Xshardware or -Xssimulation on the command line with FPGA, the device AOT compilation should be performed by aoc. This was not occuring due to the implied default device when one such object or archive was supplied on the command line. Make adjustments to our discovery of FPGA hardware/simulation mode by only checking the actual FPGA toolchain and not just the first offload toolchain encountered.
AGindinson
previously approved these changes
Oct 23, 2021
AGindinson
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using -Xshardware or -Xssimulation on the command line with
FPGA, the device AOT compilation should be performed by aoc. This
was not occuring due to the implied default device when one such
object or archive was supplied on the command line.
Make adjustments to our discovery of FPGA hardware/simulation mode
by only checking the actual FPGA toolchain and not just the first
offload toolchain encountered.