[Driver][SYCL] Fix -Xsycl option triple check with multiple -fsycl-targets #4789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ycl-targets When passing multiple -fsycl-targets on the command line, the last one wins. There is a check for the number of target triples provided by the user when applying -Xsycl-target* options to the device compilation. We were improperly counting all of the -fsycl-targets values instead of only taking into account the last one only.
AGindinson
approved these changes
Oct 23, 2021
bader
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ycl-targets
When passing multiple -fsycl-targets on the command line, the last one wins.
There is a check for the number of target triples provided by the user when
applying -Xsycl-target* options to the device compilation. We were
improperly counting all of the -fsycl-targets values instead of only taking
into account the last one only.