Skip to content

[SYCL] Disable submission of AssertInfoCopier for FPGA #4780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 10, 2021
Merged

[SYCL] Disable submission of AssertInfoCopier for FPGA #4780

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cae1ece
[SYCL] Disable submission of AssertInfoCopier for FPGA
Oct 18, 2021
9be3d15
Merge remote-tracking branch 'public/sycl' into disable-aux-kernel-su…
Dec 3, 2021
c9588af
Merge remote-tracking branch 'public/sycl' into disable-aux-kernel-su…
Dec 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions sycl/include/CL/sycl/queue.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,10 +258,11 @@ class __SYCL_EXPORT queue {
auto PostProcess = [this, &CodeLoc](bool IsKernel, bool KernelUsesAssert,
event &E) {
if (IsKernel && !device_has(aspect::ext_oneapi_native_assert) &&
KernelUsesAssert) {
KernelUsesAssert && !device_has(aspect::accelerator)) {
// __devicelib_assert_fail isn't supported by Device-side Runtime
// Linking against fallback impl of __devicelib_assert_fail is
// performed by program manager class
// Fallback assert isn't supported for FPGA
submitAssertCapture(*this, E, /* SecondaryQueue = */ nullptr,
CodeLoc);
}
Expand Down Expand Up @@ -299,7 +300,7 @@ class __SYCL_EXPORT queue {
auto PostProcess = [this, &SecondaryQueue, &CodeLoc](
bool IsKernel, bool KernelUsesAssert, event &E) {
if (IsKernel && !device_has(aspect::ext_oneapi_native_assert) &&
KernelUsesAssert) {
KernelUsesAssert && !device_has(aspect::accelerator)) {
// Only secondary queues on devices need to be added to the assert
// capture.
// TODO: Handle case where primary queue is host but the secondary
Expand All @@ -309,6 +310,7 @@ class __SYCL_EXPORT queue {
// __devicelib_assert_fail isn't supported by Device-side Runtime
// Linking against fallback impl of __devicelib_assert_fail is
// performed by program manager class
// Fallback assert isn't supported for FPGA
submitAssertCapture(*this, E, DeviceSecondaryQueue, CodeLoc);
}
};
Expand Down