[SYCL] Disallow sycl_kernel attribute on host #4618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is essentially a revert of PR intel#2186, as the supposed optimization did not materialize. I have removed the functionality added in that PR, while keeping the code cleanups.
premanandrao
requested review from
AaronBallman and
elizabethandrews
as code owners
I did not realize that SilentlyIgnore... discarded the attribute only later. Now fixed. |
elizabethandrews
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially a revert of PR #2186, as the supposed
optimization did not materialize. I have removed the
functionality added in that PR, while keeping the code
cleanups.