[SYCL] Fix warning in integration header about empty array. #4490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kernel_signatures array represents the list of fields for the kernels. When no kernel has a field, this causes a warning about the array being empty. This patch adds a 'dummy' value at the end of the array that serves 2 purposes: 1- to suppress this warning. 2- to be obvious when the runtime ends up 1 past the end of the valid array.
erichkeane
requested review from
AaronBallman,
elizabethandrews,
premanandrao and
a team
as code owners
premanandrao
previously approved these changes
Sep 3, 2021
| @@ -0,0 +1,26 @@ | |||
| // RUN: %clang_cc1 -fsycl-is-device -triple spir64-unknown-unknown -fsycl-int-header=%t.h %s -fsyntax-only | |||
| // RUN: FileCheck -input-file=%t.h %s | |||
| // This testv validates that we don't generate an empty 'kernel_signatures' in | |||
There was a problem hiding this comment.
Suggested change
| // This testv validates that we don't generate an empty 'kernel_signatures' in | |
| // This test validates that we don't generate an empty 'kernel_signatures' in |
romanovvlad
approved these changes
Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kernel_signatures array represents the list of fields for the
kernels. When no kernel has a field, this causes a warning about the
array being empty.
This patch adds a 'dummy' value at the end of the array that serves 2
purposes:
1- to suppress this warning.
2- to be obvious when the runtime ends up 1 past the end of the valid
array.