Skip to content

[SYCL][NFC] Drop on-device tests in favor of llvm-test-suite #4393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 30, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,6 @@ There are 3 types of tests which are used for DPC++ toolchain validation:
should not have hardware (e.g. GPU, FPGA, etc.) or external software
dependencies (e.g. OpenCL, Level Zero, CUDA runtimes). All tests not following
this approach should be moved to DPC++ end-to-end or SYCL-CTS tests.
However, the tests for a feature under active development requiring atomic
change for tests and product can be put to
[sycl/test/on-device](../../sycl/test/on-device) temporarily. It is developer
responsibility to move the tests to DPC++ E2E test suite or SYCL-CTS once
the feature is stabilized.

**Guidelines for adding DPC++ in-tree LIT tests (DPC++ Clang FE tests)**:
- Use `sycl::` namespace instead of `cl::sycl::`
Expand Down
1 change: 0 additions & 1 deletion sycl/test/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -105,4 +105,3 @@ if(SYCL_BUILD_PI_ROCM)

add_dependencies(check-sycl check-sycl-rocm)
endif()
add_subdirectory(on-device)
2 changes: 1 addition & 1 deletion sycl/test/lit.cfg.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
config.suffixes = ['.c', '.cpp', '.dump'] #add .spv. Currently not clear what to do with those

# feature tests are considered not so lightweight, so, they are excluded by default
config.excludes = ['Inputs', 'feature-tests', 'on-device']
config.excludes = ['Inputs', 'feature-tests']

# test_source_root: The root path where tests are located.
config.test_source_root = os.path.dirname(__file__)
Expand Down
56 changes: 0 additions & 56 deletions sycl/test/on-device/CMakeLists.txt

This file was deleted.

70 changes: 0 additions & 70 deletions sycl/test/on-device/README.md

This file was deleted.

73 changes: 0 additions & 73 deletions sycl/test/on-device/back_to_back_collectives.cpp

This file was deleted.

106 changes: 0 additions & 106 deletions sycl/test/on-device/basic_tests/aspects.cpp

This file was deleted.

51 changes: 0 additions & 51 deletions sycl/test/on-device/basic_tests/diagnostics/device-check.cpp

This file was deleted.

Loading