Skip to content

[SYCL][CUDA] Windows and MSVC support for CUDA backend #4345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 13, 2021
Merged

[SYCL][CUDA] Windows and MSVC support for CUDA backend #4345

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ff947d1
[SYCL][CUDA] Add support for MSVC
Apr 23, 2021
07c5d81
Merge upstream commits
Aug 16, 2021
02a8426
Added comments for wchar_size drop
Aug 19, 2021
cf1279b
Update from feedback
Aug 25, 2021
ecb24c4
clang format
Aug 25, 2021
d250087
resolve conflict
Sep 3, 2021
aa27c35
Update CMake based on feedback
Sep 7, 2021
2826576
Set test_contexts to use std::optional
Sep 7, 2021
6c8cc47
Partly undo CMake changes based on feedback
Sep 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added comments for wchar_size drop
  • Loading branch information
aidan.belton committed Aug 19, 2021
commit 02a842628a218e58b6718150e92974eaa3d899cc
3 changes: 2 additions & 1 deletion libclc/utils/prepare-builtins.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ int main(int argc, char **argv) {
if (NamedMDNode *OCLVersion = M->getNamedMetadata("opencl.ocl.version"))
M->eraseNamedMetadata(OCLVersion);

// Drop wchar_size module flag
//wchar_size flag can cause a mismatch between libclc libraries and
//modules using them. Since wchar is not used by libclc we drop the flag
if (M->getModuleFlag("wchar_size")) {
SmallVector<Module::ModuleFlagEntry, 4> ModuleFlags;
M->getModuleFlagsMetadata(ModuleFlags);
Expand Down