-
Notifications
You must be signed in to change notification settings - Fork 773
[SYCL] Ensure int-header fwd decls work with references #4281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We weren't properly descending down into reference types, so we ended up not forward declaring any types that were referred to only as a reference type. This patch ensures we do so, just like we did with pointer-type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
3rd time is hopefuly the charm on Jenkins/Precommit! 1st two got hit with different flakey test failures. |
@bader Another similar story. 1st failure was LLVM test suite WINDOWS, test was ESIMD/matrix_transpose.cpp 2nd failure was LLVM test suite LINUX, test was Reduction/reduction_nd_N_vars.cpp 3rd failure was LLVM test suite Windows again, test was Reduction/reduction_nd_N_vars.cpp (again, note windows vs linux) This patch simply corrects a build error, so I don't think I could have caused this. |
@v-klochkov, @DenisBakhvalov, FYI. ESIMD and reduction tests seem to generate in a lot of false positives in pre-commit CI. It would be great if you can help to reduce the noise. |
ESIMD/matrix_transpose.cpp is fixed. If you rerun the CI, you should not see it again. |
We weren't properly descending down into reference types, so we ended up
not forward declaring any types that were referred to only as a
reference type. This patch ensures we do so, just like we did with
pointer-type.