Skip to content

[SYCL] Ensure int-header fwd decls work with references #4281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

erichkeane
Copy link
Contributor

We weren't properly descending down into reference types, so we ended up
not forward declaring any types that were referred to only as a
reference type. This patch ensures we do so, just like we did with
pointer-type.

We weren't properly descending down into reference types, so we ended up
not forward declaring any types that were referred to only as a
reference type.  This patch ensures we do so, just like we did with
pointer-type.
Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erichkeane
Copy link
Contributor Author

@DoyleLi and @tfzhu and @bader : Looks like the Lit_With_Cuda bot is out of hard disk space again!

Copy link
Contributor

@AaronBallman AaronBallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DoyleLi
Copy link
Contributor

DoyleLi commented Aug 8, 2021

@DoyleLi and @tfzhu and @bader : Looks like the Lit_With_Cuda bot is out of hard disk space again!

It seems the system was used by someone and some configuration also changed. I have locked it.

@erichkeane
Copy link
Contributor Author

3rd time is hopefuly the charm on Jenkins/Precommit! 1st two got hit with different flakey test failures.

@erichkeane
Copy link
Contributor Author

@bader Another similar story.

1st failure was LLVM test suite WINDOWS, test was ESIMD/matrix_transpose.cpp
http://icl-jenkins.sc.intel.com:8080/blue/organizations/jenkins/SYCL_CI%2Fintel%2FPrecommit_Check_User/detail/Precommit_Check_User/8347/pipeline/

2nd failure was LLVM test suite LINUX, test was Reduction/reduction_nd_N_vars.cpp
http://icl-jenkins.sc.intel.com:8080/blue/organizations/jenkins/SYCL_CI%2Fintel%2FPrecommit_Check_User/detail/Precommit_Check_User/8389/pipeline/

3rd failure was LLVM test suite Windows again, test was Reduction/reduction_nd_N_vars.cpp (again, note windows vs linux)
http://icl-jenkins.sc.intel.com:8080/blue/organizations/jenkins/SYCL_CI%2Fintel%2FPrecommit_Check_User/detail/Precommit_Check_User/8398/pipeline/

This patch simply corrects a build error, so I don't think I could have caused this.

@bader
Copy link
Contributor

bader commented Aug 10, 2021

@v-klochkov, @DenisBakhvalov, FYI. ESIMD and reduction tests seem to generate in a lot of false positives in pre-commit CI. It would be great if you can help to reduce the noise.

@DenisBakhvalov
Copy link
Contributor

@v-klochkov, @DenisBakhvalov, FYI. ESIMD and reduction tests seem to generate in a lot of false positives in pre-commit CI. It would be great if you can help to reduce the noise.

ESIMD/matrix_transpose.cpp is fixed. If you rerun the CI, you should not see it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants