[SYCL] Fix some Doxygen build warnings #4170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done as a part of intel#4140
|
@vmaksimo, thank you for fixing this! |
This is only the first step, but it should be a good start to fix the rest warnings :) |
s-kanaev
reviewed
Jul 23, 2021
Comment on lines
-435
to
-437
| /// \param Pointer to the stream object | ||
| /// \param Size of the stream buffer | ||
| /// \param Size of the flush buffer for a single work item |
There was a problem hiding this comment.
Will it really help without naming of arguments?
There was a problem hiding this comment.
I believe it's better to leave the documentation with named arguments as it was planned by the author
smaslov-intel
approved these changes
Jul 23, 2021
zahiraam
pushed a commit
to zahiraam/llvm-1
that referenced
this pull request
Aug 2, 2021
This is done as a part of intel#4140 * Changed several parameter types to parameter argument names (under \param tag) * Renamed parameter names as they were changes in code, but not in documentation comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done as a part of #4140