[SYCL] Construct context from first device in unit tests #4142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because multiple devices in a context is not supported with AOT compiling, which is always used for the CUDA and ROCm pluginis, and constructing the context from the platform may result in multiple devices in the context if there are multiple devices available on the system. These tests are run with a device filter so this will only happen when there is multiple devices of the same type. Which also means that it should always be fine to take the first device from the platform as it should still be of the expected device type.
|
@dm-vodopyanov, @intel/llvm-reviewers-runtime, ping. |
alexbatashev
approved these changes
Jul 30, 2021
zahiraam
pushed a commit
to zahiraam/llvm-1
that referenced
this pull request
Aug 2, 2021
This is because multiple devices in a context is not supported with AOT compiling, which is always used for the CUDA and ROCm pluginis, and constructing the context from the platform may result in multiple devices in the context if there are multiple devices available on the system. These tests are run with a device filter so this will only happen when there is multiple devices of the same type. Which also means that it should always be fine to take the first device from the platform as it should still be of the expected device type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because multiple devices in a context is not supported with AOT
compiling, which is always used for the CUDA and ROCm pluginis, and
constructing the context from the platform may result in multiple
devices in the context if there are multiple devices available on the
system.
These tests are run with a device filter so this will only happen
when there is multiple devices of the same type. Which also means that
it should always be fine to take the first device from the platform as
it should still be of the expected device type.