Skip to content

[SYCL][Doc] Update docs to reflect new compiler features #4030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 30, 2021
Merged

[SYCL][Doc] Update docs to reflect new compiler features #4030

merged 3 commits into from
Jun 30, 2021

Conversation

AGindinson
Copy link
Contributor

Signed-off-by: Artem Gindinson artem.gindinson@intel.com

[SYCL][Doc] Update docs to reflect new compiler features
221cda3 
Signed-off-by: Artem Gindinson <artem.gindinson@intel.com>
mdtoguchi
mdtoguchi reviewed Jun 30, 2021
View reviewed changes
bader
bader reviewed Jun 30, 2021
View reviewed changes
Address review comments
a0f4fc4 
Signed-off-by: Artem Gindinson <artem.gindinson@intel.com>
@AGindinson AGindinson requested review from bader and mdtoguchi June 30, 2021 17:52
bader
bader reviewed Jun 30, 2021
View reviewed changes
Limit line length to 80 characters
6096745 
Signed-off-by: Artem Gindinson <artem.gindinson@intel.com>
bader
bader approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pvchupin pvchupin merged commit 807fdae into intel:sycl Jun 30, 2021
@pvchupin
Copy link
Contributor

@AGindinson, please try to avoid empty PR description next time so that it can be copy-pasted as commit message.

@AGindinson
Copy link
Contributor Author

@AGindinson, please try to avoid empty PR description next time so that it can be copy-pasted as commit message.

@pvchupin, sure, sorry for the inconvenience.

@AGindinson AGindinson deleted the docs-new-features branch July 1, 2021 05:19
@bader
Copy link
Contributor

bader commented Jul 1, 2021

please try to avoid empty PR description next time so that it can be copy-pasted as commit message.

Not sure if this is a problem in general.
I think it's possible that all I have to say about some simple patch can fit into PR title, so I don't need to waffle in the description.

@pvchupin
Copy link
Contributor

pvchupin commented Jul 1, 2021

Not sure if this is a problem in general.
I think it's possible that all I have to say about some simple patch can fit into PR title, so I don't need to waffle in the description.

I strongly believe cases where you don't need commit message are exceptional, rather than general, and ok for very trivial cases only. Don't need to waffle, but spend 2 minutes to summarize what's been done.
You may find this interesting: https://chris.beams.io/posts/git-commit/#why-not-how

alexbatashev added a commit to alexbatashev/llvm that referenced this pull request Jul 2, 2021
@alexbatashev
Merge remote-tracking branch 'upstream/sycl' into xpti_pi_args
b236f2c 
* upstream/sycl: (649 commits)
  [SYCL][Driver][NFC] Update integration footer test for 32-bit host (intel#4039)
  [SYCL][L0] Initialize descriptor .stype and .pNext (intel#4032)
  [SYCL] Add sycl::kernel::get_kernel_bundle method (intel#3855)
  [SYCL] Add support for device UUID as a SYCL extension. (intel#3696)
  [SYCL][Matrix] Add spec document for the matrix extension interface and its first implementation for AMX (intel#3551)
  Fix debug build mangler test after PR#3992 (8f38045). (intel#4033)
  [Driver][SYCL] Restrict user -include file in final integration footer step (intel#4036)
  [SYCL] [Tests] Do not copy device binary image mocks (intel#4023)
  [SYCL][Doc] Update docs to reflect new compiler features (intel#4030)
  [SYCL][CUDA] cl_khr_fp16 extension connected to cuda PI. (intel#4029)
  [SYCL][NFC] Refactor RT unit tests (intel#4021)
  [SYCL] Switch to using integration footer by default (intel#3777)
  [SYCL][CUDA] Add the Use Default Stream property (intel#4004)
  Uplift GPU RT version for Linux to 21.24.20098 (intel#4003)
  [SYCL][CUDA] atomic_ref.fetch_add used for fp64 reduction if device.has(atomic64) (intel#3950)
  [Driver][SYCL] Differentiate host dependency link from regular host link (intel#4002)
  [SYCL][ESIMD] Support device half type in intrinsics. (intel#4024)
  [SYCL] Allow fpga_reg only for PODs and Trivially-copyable structs (intel#3643)
  [SYCL][FPGA] Restore legacy debug info version for the hardware (intel#3991)
  [SYCL][PI][L0] Force reset of memcpy command-list. (intel#4001)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader approved these changes

@pvchupin pvchupin pvchupin approved these changes

@mdtoguchi mdtoguchi mdtoguchi approved these changes

@alexbatashev alexbatashev Awaiting requested review from alexbatashev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AGindinson @pvchupin @bader @mdtoguchi