Skip to content

[SYCL] Move __ENABLE_USM_ADDR_SPACE__ initialization into FE #3993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2021

Conversation

AGindinson
Copy link
Contributor

Also restores unit-level testing for this target-specific macro.

Signed-off-by: Artem Gindinson artem.gindinson@intel.com

Also restores unit-level testing for this target-specific macro.

Signed-off-by: Artem Gindinson <artem.gindinson@intel.com>
AaronBallman
AaronBallman previously approved these changes Jun 24, 2021
Copy link
Contributor

@AaronBallman AaronBallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from a style nit.

MrSidims
MrSidims previously approved these changes Jun 24, 2021
mdtoguchi
mdtoguchi previously approved these changes Jun 24, 2021
Co-authored-by: Aaron Ballman <aaron@aaronballman.com>
Copy link
Contributor

@AaronBallman AaronBallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader bader merged commit 107bbd0 into intel:sycl Jun 27, 2021
@AGindinson AGindinson deleted the device-macro-init branch June 28, 2021 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move SYCL device-side macro initialization from Driver into FE
6 participants