Skip to content

[SYCL-PTX] Fix missing callsite metadata after global offset pass #3736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 13, 2021
Merged

[SYCL-PTX] Fix missing callsite metadata after global offset pass #3736

merged 2 commits into from
May 13, 2021

Conversation

steffenlarsen
Copy link
Contributor

Fixes the implicit global offset pass not copying callsite metadata.

[SYCL-PTX] Fix missing callsite metadata after global offset pass
e5b578f 
This commit fixes the implicit global offset pass not copying callsite
metadata.

Signed-off-by: Steffen Larsen <steffen.larsen@codeplay.com>
@steffenlarsen steffenlarsen requested a review from bader as a code owner May 12, 2021 15:38
@steffenlarsen steffenlarsen mentioned this pull request May 12, 2021
Merged
@steffenlarsen
Copy link
Contributor Author

Regression test: intel/llvm-test-suite#279

@bader
Copy link
Contributor

bader commented May 12, 2021

Regression test: intel/llvm-test-suite#279

Ideally we should extend llvm/test/CodeGen/NVPTX/global-offset-* tests to catch regressions with check-llvm test suite instead of running end-to-end testing. @steffenlarsen, could you add a small reproducer to llvm LIT tests, please?

@bader bader added the cuda CUDA back-end label May 12, 2021
Adds codegen test for debug info preservation
ed9e47f 
Signed-off-by: Steffen Larsen <steffen.larsen@codeplay.com>
@steffenlarsen
Copy link
Contributor Author

Ideally we should extend llvm/test/CodeGen/NVPTX/global-offset-* tests to catch regressions with check-llvm test suite instead of running end-to-end testing. @steffenlarsen, could you add a small reproducer to llvm LIT tests, please?

Good call. I have added a simple test adjusted from llvm/test/CodeGen/NVPTX/global-offset-simple.ll to check that debug information is copied and preserved correctly.

bader
bader approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bader bader merged commit 5612030 into intel:sycl May 13, 2021
@steffenlarsen steffenlarsen deleted the steffen/fix-debug-opts branch December 6, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader approved these changes

Assignees
No one assigned
Labels
cuda CUDA back-end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steffenlarsen @bader