-
Notifications
You must be signed in to change notification settings - Fork 769
Stream class fe #3715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stream class fe #3715
Conversation
Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
@DenisBakhvalov As you suggested in #3646 I have split the patch. This one has all the FE changes but I am getting some fails in the sycl tests. Can you please take and help me figure out what can be the issue? I am wondering if it is really possible to split the the PR? |
Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
@Fznamznon I am in the process of splitting the patch into FE changes and sycl changes as recommended by @DenisBakhvalov in #3646 in order to understand the ESIMD run fails. I am getting these new sycl fails (it's hard to reproduce them locally as llvm-lit doesn't seem to be working for these). Would you mind taking a look at them to help me find out the issue(s). I am wondering if it is actually possible to split the patch? |
I'm not sure it is the right idea. If you make a change to stream handling in FE, you need to modify stream class in headers as well, otherwise it won't work.
How did you get them? I can't find any "/summary:run" command in #3646 . Do we have ESIMD tests in default precommit? |
Thanks. That's what I thought! It looks like we do. In #3646 the fails are in Jenkins/precommit. These are the fails I am getting: [2021-05-18T12:39:02.572Z] SYCL :: ESIMD/BitonicSortK.cpp [2021-05-18T12:39:02.572Z] SYCL :: ESIMD/accessor.cpp [2021-05-18T12:39:02.572Z] SYCL :: ESIMD/ext_math.cpp [2021-05-18T12:39:02.572Z] SYCL :: ESIMD/fp_call_from_func.cpp [2021-05-18T12:39:02.572Z] SYCL :: ESIMD/noinline_call_from_func.cpp [2021-05-18T12:39:02.572Z] SYCL :: ESIMD/regression/big_const_initializer.cpp [2021-05-18T12:39:02.572Z] SYCL :: ESIMD/regression/unused_load.cpp [2021-05-18T12:39:02.572Z] SYCL :: ESIMD/spec_const/spec_const_bool.cpp [2021-05-18T12:39:02.572Z] SYCL :: ESIMD/spec_const/spec_const_char.cpp [2021-05-18T12:39:02.572Z] SYCL :: ESIMD/spec_const/spec_const_double.cpp [2021-05-18T12:39:02.572Z] SYCL :: ESIMD/spec_const/spec_const_float.cpp [2021-05-18T12:39:02.572Z] SYCL :: ESIMD/spec_const/spec_const_int.cpp [2021-05-18T12:39:02.572Z] SYCL :: ESIMD/spec_const/spec_const_int64.cpp [2021-05-18T12:39:02.572Z] SYCL :: ESIMD/spec_const/spec_const_short.cpp [2021-05-18T12:39:02.572Z] SYCL :: ESIMD/spec_const/spec_const_uchar.cpp [2021-05-18T12:39:02.572Z] SYCL :: ESIMD/spec_const/spec_const_uint.cpp [2021-05-18T12:39:02.572Z] SYCL :: ESIMD/spec_const/spec_const_uint64.cpp [2021-05-18T12:39:02.572Z] SYCL :: ESIMD/spec_const/spec_const_ushort.cpp [2021-05-18T12:39:02.572Z] SYCL :: ESIMD/spec_const_redefine_esimd.cpp [2021-05-18T12:39:02.572Z] SYCL :: ESIMD/sycl_esimd_mix.cpp [2021-05-18T12:39:02.572Z] SYCL :: ESIMD/vadd_1d.cpp [2021-05-18T12:39:02.572Z] SYCL :: ESIMD/vadd_2d_acc.cpp [2021-05-18T12:39:02.572Z] SYCL :: ESIMD/vadd_raw_send.cpp [2021-05-18T12:39:02.572Z] [2021-05-18T12:39:02.572Z] [2021-05-18T12:39:02.572Z] Testing Time: 1033.48s [2021-05-18T12:39:02.572Z] Unsupported : 72 [2021-05-18T12:39:02.572Z] Passed : 400 [2021-05-18T12:39:02.572Z] Expectedly Failed: 16 [2021-05-18T12:39:02.572Z] Failed : 23 |
In order to understand the ESIMD failures in github.com//pull/3646 , the patch is split into FE code and sycl. This is the FE side changes to align the stream class with the other classes.