Skip to content

[NFC][SYCL] Apply post-commit comments to ITT annotation support #3691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2021

Conversation

MrSidims
Copy link
Contributor

@MrSidims MrSidims commented May 4, 2021

Signed-off-by: Dmitry Sidorov dmitry.sidorov@intel.com

Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
@MrSidims
Copy link
Contributor Author

MrSidims commented May 4, 2021

Addresses post commit comments from #3299 with an exception of RT-known memory order handling

Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BackendUtil.cpp change looks okay to me. Someone else will need to approve the other changes.

@bader bader merged commit a7b8daf into intel:sycl May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants