Skip to content

[SYCL] Fix kernel::get_native #3655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2021
Merged

Conversation

alexbatashev
Copy link
Contributor

@alexbatashev alexbatashev commented Apr 29, 2021

This patch fixes compilation errors with kernel::get_native usage and improves test coverage for this method

@alexbatashev alexbatashev marked this pull request as ready for review April 29, 2021 11:07
@alexbatashev alexbatashev requested a review from a team as a code owner April 29, 2021 11:07
@alexbatashev alexbatashev requested a review from s-kanaev April 29, 2021 11:07
s-kanaev
s-kanaev previously approved these changes Apr 29, 2021
Copy link
Contributor

@s-kanaev s-kanaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.
@alexbatashev , could you, please, provide a brief description of the problem being fixed in patch description?

@bader bader merged commit eb17836 into intel:sycl Apr 30, 2021
Michoumichmich added a commit to Michoumichmich/llvm that referenced this pull request Sep 10, 2021
@alexbatashev alexbatashev deleted the fix_kernel_get_native branch September 17, 2021 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants