[Driver][SYCL] Enable multi-file for AOT #3609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When dealing with AOT compilations, we explicitly turned off multi-file processing. This behavior was preventing kernel name table generation. This effectively makes multi-file the default for all modes.
|
/summary:run |
AGindinson
reviewed
Apr 26, 2021
There was a problem hiding this comment.
The implementation LGTM - still, I'd appreciate if @kbobrovs could take a look as well.
|
@mdtoguchi, can you please resolve CI failure, resolve merge conflict and proceed with asking for a review as soon as possible? |
kbobrovs
reviewed
Apr 29, 2021
| types::ID PostLinkOutType = isNVPTX || !MultiFileActionDeps | ||
| ? types::TY_LLVM_BC | ||
| : types::TY_Tempfiletable; | ||
| types::ID PostLinkOutType = |
There was a problem hiding this comment.
please update the picture and the doc
AGindinson
previously approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dealing with AOT compilations, we explicitly turned off multi-file
processing. This behavior was preventing kernel name table generation.
This effectively makes multi-file the default for all modes.