[NFC][sycl-post-link] Add test with zeroinitialied spec constants #3591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusted assertions to accept zeroinitializer for specialization_id variables, as it is a valid situation. The rest of the code wasn't changed, because it works fine with such initializers already.
vmaksimo
previously approved these changes
Apr 26, 2021
|
@kbobrovs, could you please take a look as a code owner? |
AlexeySachkov
changed the title
kbobrovs
suggested changes
Apr 29, 2021
llvm/test/tools/sycl-post-link/spec-constants/SYCL-2020-zeroinitializer.ll
Outdated
Show resolved
Hide resolved
llvm/test/tools/sycl-post-link/spec-constants/SYCL-2020-zeroinitializer.ll
Show resolved
Hide resolved
…oinitializer-as-spec-constant-default-value
kbobrovs
approved these changes
Apr 29, 2021
|
@AlexeySachkov, please, address pre-commit testing failures. |
AlexeySachkov
deleted the
private/asachkov/support-zeroinitializer-as-spec-constant-default-value
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted assertions to accept zeroinitializer for specialization_id
variables, as it is a valid situation. The rest of the code wasn't
changed, because it works fine with such initializers already.