[sycl-post-link] Add support of spec constant default values #3513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added handling of the second argument of `__sycl_get*2020SpecConstantValue` intrinsic.
vmaksimo
reviewed
Apr 8, 2021
|
@kbobrovs, could you please take a look? |
bader
changed the title
vmaksimo
approved these changes
Apr 15, 2021
|
@kbobrovs, ping |
kbobrovs
approved these changes
Apr 21, 2021
AlexeySachkov
added a commit
to AlexeySachkov/llvm
that referenced
this pull request
May 13, 2021
Due to changes in `SpecConstatsPass` introduced by intel#3513, device image properties for specialization constants are now computed in a bit different way: in particular they are calculated based on metadata generated by the pass and not by looking at the SPIR-V friendly IR intrinsics left in the module. Such change caused a regression: if device code split was used together with specialization constants, each resulting device image was supplied with list of *all* specialization constants found in the _original_ undivided module. In combination with some DPC++ RT changes it lead to setting non-existing specialization constants. This patch fixed the regression by performing device code split step *before* handling specialization constants.
bader
pushed a commit
that referenced
this pull request
May 15, 2021
Due to changes in `SpecConstatsPass` introduced by #3513, device image properties for specialization constants are now computed in a bit different way: in particular they are calculated based on metadata generated by the pass and not by looking at the SPIR-V friendly IR intrinsics left in the module. Such change caused a regression: if device code split was used together with specialization constants, each resulting device image was supplied with list of *all* specialization constants found in the _original_ undivided module. In combination with some DPC++ RT changes it lead to setting non-existing specialization constants. This patch fixed the regression by performing device code split step *before* handling specialization constants.
AlexeySachkov
deleted the
private/asachkov/spec-constants-default-values-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added handling of the second argument of
__sycl_get*2020SpecConstantValueintrinsic.